Repository navigation
feat: mark organization commits with an inline badge #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PacketByte
wants to merge
1
commit into
dev-null-sh:production
Choose a base branch
from
PacketByte:feat/org-commit-marker
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Marks a commit posted as an organization, right after its handle. People and | ||
| * organizations otherwise share the same header, and the square avatar alone is | ||
| * easy to miss in a busy log. It sits next to the author on purpose: what the | ||
| * commit was posted from (web, CLI, apps) belongs next to the timestamp instead. | ||
| */ | ||
| export function OrganizationBadge({ handle }: { handle: string }) { | ||
| return ( | ||
| <span | ||
| className="shrink-0 self-center rounded-sm bg-muted px-2 py-0.5 font-mono text-xs text-muted-foreground" | ||
| title={`Posted by the @${handle} organization`} | ||
| data-test="organization-badge" | ||
| > | ||
| Organization | ||
| </span> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /// <reference types="node" /> | ||
| import assert from 'node:assert/strict'; | ||
| import { renderToStaticMarkup } from 'react-dom/server'; | ||
| import { test } from 'vite-plus/test'; | ||
| import { OrganizationBadge } from '../../resources/js/components/organization-badge'; | ||
|
|
||
| test('labels the badge with the organization that posted the commit', () => { | ||
| const html = renderToStaticMarkup(<OrganizationBadge handle="laravel" />); | ||
|
|
||
| assert.match(html, /Organization/); | ||
| assert.match(html, /title="Posted by the @laravel organization"/); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the author visible on narrow screens.
On a narrow viewport, this fixed-width badge shares a non-wrapping row with the timestamp and any commit-status badge. For a pending organization commit, those items can consume the row before the author links receive space. The header can then truncate the organization’s name and handle. Give the author priority, and move the badge to another line when space is limited. (raw.githubusercontent.com)