Fix stale glossary-sensitive output adoption - #37
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Untracked
output_chunk*.mdfiles were record-only adopted by default even when their source chunks selected current glossary terms. In a resumed or manually edited temp dir, stale translations could be stamped intorun_state.jsonas current, causing later runs to skip required re-translation and silently preserve wrong terminology in final book outputs.Root cause
run_state.plan()handled every existing output without a state record asrecordunless--retranslate-untrackedwas set. Separately,glossary.term_hash()ignored aliases, so alias-only glossary edits for already-selected terms did not invalidate recorded chunks.Fix
Validation
output_chunk0001.mdwas recorded as unchanged.python3 -m unittest tests.test_run_state tests.test_glossary -vpassed (68 tests).python3 -m unittest discover -s tests -p 'test_*.py' -vpassed (209 tests, 3 skipped).python3 -m compileall scripts testspassed.chunk0001intranslation_chunk_idsthroughrecord-all, while record-only adopting glossary-freechunk0002.