Fix conversion data-loss paths in convert.py - #35
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
convert.pywrote Calibre's temporary HTMLZ output next to the input file as<input-stem>.htmlzand deleted that path after extraction. If a user already had a siblingbook.htmlz, conversion overwrote and then deleted user-owned data.1,2,3,4could lose content before chunking; the manifest then hashed the already-truncated source, so later validation could not detect the loss.Root cause
input_fileinstead of a private temp directory.Fix
tempfile.TemporaryDirectory(prefix="<book>_htmlz_")and remove the sibling-path cleanup.--auto-strip-page-numbersfor the existing monotonic-page heuristic and keep--strip-page-numbersfor aggressive legacy cleanup.Validation
python3 -m unittest tests.test_convert -v— 19 passed.1..4;auto_strip_page_numbers=Trueremoves them; conversion uses/tmp/book_htmlz_.../book.htmlz; siblingbook.htmlzremains with contentUSER DATA.python3 -m unittest discover -s tests -p 'test_*.py' -v— 207 passed, 3 skipped.python3 -m compileall scripts tests— passed.