Fix run_state adoption of glossary-sensitive stale outputs - #34
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Untracked
output_chunk*.mdfiles were accepted as record-only even when their source chunk selected terms from the current glossary. A stale translated chunk could be recorded under the new glossary and then become permanentlyunchanged, silently preserving wrong terminology in final book outputs. Alias-only edits to an already-selected term were also ignored because aliases were omitted from the per-term hash.Root cause
run_state.plan()treated every existing output without arun_state.jsonrecord as safe to adopt unless--retranslate-untrackedwas passed.glossary.term_hash()hashed only source/target/category even though aliases are injected into subagent prompts.Fix
Validation
chunk0001record-only, then permanently unchanged afterrecord-alland alias edits.chunk0001intranslation_chunk_ids,chunk0002record-only, and alias edits retriggerchunk0001.python3 -m unittest tests.test_run_state tests.test_glossary -v(68 tests OK)python3 -m unittest discover -s tests -p 'test_*.py' -v(209 tests OK, 3 skipped)python3 -m compileall scripts tests