Fix stale adoption of glossary-sensitive untracked outputs - #33
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Untracked existing
output_chunk*.mdfiles were record-only by default, even when the current glossary selected terms for that chunk. After a glossary edit or legacy adoption, stale translations could be recorded under the new glossary state and then skipped forever, silently shipping incorrect terminology.Root cause
scripts/run_state.py plan()classified missingrun_state.jsonrecords asrecordbefore running glossary selection/hash checks.glossary.term_hash()also omitted aliases even though aliases are part of the prompt table.Fix
Validation
chunk0001withTaiincorrectly planned asrecord_only; post-fix repro plans it for translation and keeps only glossary-freechunk0002record-only.python3 -m unittest tests.test_run_state tests.test_glossary -v(69 tests)python3 -m unittest discover -s tests -p 'test_*.py' -v(210 tests, 3 skipped)python3 -m compileall scripts tests