Fix stale glossary-sensitive outputs in selective retranslation - #32
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
deusyu
force-pushed
the
cursor/critical-bug-investigation-845e
branch
from
June 26, 2026 02:15
507c3eb to
ae54c79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Existing translated chunks without
run_state.jsonrecords were treated asrecord_onlyby default, even when the current glossary selected terms for that chunk. The skill recordsrecord_only_chunk_idsbefore launching subagents, so a stale translation from an old glossary could be stamped as current and then skipped forever. Alias-only glossary edits also did not change per-term hashes, so already-selected chunks could miss prompt-affecting alias changes.Root cause
run_state.plan()did not inspect selected glossary terms before adopting untracked outputs, andglossary.term_hash()only hashed source/target/category, omitting aliases that are injected into the prompt term table.Fix
term_hash()when aliases are present, preserving hash compatibility for no-alias records.Validation
chunk0001was record-only and became unchanged afterrecord-all; alias-only change was unchanged.chunk0001stays intranslation_chunk_ids, only glossary-freechunk0002is record-only; alias-only change triggers translation.python3 -m unittest tests.test_run_state tests.test_glossary -v(68 tests)python3 -m unittest discover -s tests -p 'test_*.py' -v(209 tests, 3 skipped)python3 -m compileall scripts tests