Fix stale glossary-sensitive output adoption - #30
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
deusyu
force-pushed
the
cursor/critical-bug-investigation-071c
branch
from
June 26, 2026 02:15
5f57236 to
2611f00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Untracked
output_chunk*.mdfiles were record-only by default even when their source chunk selected current glossary terms. A stale translation could be written intorun_state.jsonas if it used the current glossary, causing future selective runs to skip it and ship inconsistent terminology. Alias-only glossary edits for already-selected terms were also not included in term hashes.Root cause
run_state.plan()treated all existing outputs without records as safe to adopt unless--retranslate-untrackedwas passed, andglossary.term_hash()ignoredaliaseseven though aliases are injected into chunk prompts.Fix
Validation
python3 -m unittest tests.test_run_state tests.test_glossary -vpython3 -m compileall scripts testspython3 -m unittest discover -s tests -p 'test_*.py' -v(209 tests, 3 skipped)translation_chunk_idsthrough record-only adoption, and alias-only changes triggerglossary_term_hash_changed.