Fix stale glossary-sensitive output adoption - #29
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
deusyu
force-pushed
the
cursor/critical-bug-investigation-a6d8
branch
from
June 26, 2026 02:15
236c63b to
291a0f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Selective re-translation could silently adopt existing
output_chunk*.mdfiles that had norun_state.jsonrecord, even when the current source chunk selected glossary terms. If the output was produced before a glossary edit,record-allstamped the stale translation as current and future plans reported it unchanged, causing persistent terminology corruption in final books.Root cause
run_state.plan()treated every untracked existing output as record-only by default, without checking whether the current glossary would be injected into that chunk.glossary.term_hash()also ignored aliases, so alias-only prompt changes for already-selected terms did not invalidate prior records.Fix
record-alladoption, and alias hash changes.Validation
python3 -m unittest tests.test_run_state tests.test_glossary -vpython3 -m compileall scripts testspython3 -m unittest discover -s tests -p 'test_*.py' -v(209 tests, 3 skipped)chunk0001intranslation_chunk_idsbefore and afterrecord-all.