Fix selective retranslation for untracked glossary-sensitive chunks - #28
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Rainman <deusyu@users.noreply.github.com>
deusyu
force-pushed
the
cursor/critical-bug-investigation-365b
branch
from
June 26, 2026 02:15
353d1f1 to
45d3550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Existing
output_chunk*.mdfiles withoutrun_state.jsonrecords were adopted as record-only before checking whether the current glossary affected the chunk. A stale translation could be recorded as if it already used the current glossary, then skipped forever asunchanged. Alias-only glossary edits for already-selected terms could also be missed because aliases were not part of the per-term hash.Root cause
run_state.plan()short-circuited untracked existing outputs torecordbefore glossary term selection/hash checks, andglossary.term_hash()only hashed source, target, and category.Fix
term_hash()when aliases are present, preserving no-alias hash compatibility.Validation
chunk0001was recorded and then markedunchanged.chunk0001intranslation_chunk_idsthroughrecord-all, while record-only adopting glossary-freechunk0002.python3 -m unittest tests.test_run_state tests.test_glossary -v(66 tests OK)python3 -m unittest discover -s tests -p 'test_*.py' -v(207 tests OK, 3 skipped)python3 -m compileall scripts tests