Exclude docs/old/** from the VitePress build (premise partly refuted — see body) - #100
Merged
Conversation
`docs/old/` holds two superseded planning notes. They were being compiled into the site output as `/old/phlix_update` and `/old/worklog`, reachable by direct URL and indexed by the local search provider. Verified the premise before applying the recorded fix, and it is only half true. `docs/old/` is gitignored (.gitignore:9) and untracked, so `actions/checkout` never materialises it and neither `Build Docs` nor `Deploy Docs` has ever seen those files. The published site has therefore never contained the pages, and this commit does not remove anything from what ships. What it does remove is the local-vs-CI divergence. On a developer checkout the files are present and get built, so every locally measured figure disagrees with CI — 160 pages / 3613 links locally against 158 / 3474 in a clean checkout. A local corpus number consequently could not be compared with the CI one, which has already cost review time. With the exclusion a local build on a tree that still contains the files reports 158 / 3474, byte-identical to the clean-checkout control. Scoped to `old/**` only. `archive/` lives at the repository root, outside VitePress's `docs` srcDir, and was confirmed absent from the build output; it needs no exclusion. Checked for inbound links before excluding — no live page links into `old/**` in either the markdown source or the emitted HTML (the sole grep hit was "household/" in parental-controls.md matching the substring "old/"), so the exclusion creates no dead anchors. The test asserts the resolved `srcExclude` export rather than the config file's text, because a text match would also be satisfied by the comment that explains the option. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the
docs/old/follow-up recorded in S192's ship note.⚠ The premise was partly refuted — read before merging
docs/old/is built by VitePress, but it is untracked, soactions/checkoutnever sees it and the published site has never contained those pages. If the goal was removing something live from the site, this is a no-op and the follow-up could simply be closed instead.The real benefit is killing local-vs-CI divergence: a local build went 160 pages / 3613 links → 158 / 3474, identical to the CI-faithful control. That divergence is what made a local page count untrustworthy as evidence, which cost time twice in the last two days.
archive/is outside thedocssrcDir and needs nothing.No dead anchors created
Checked before excluding: zero inbound links to
old/**. Excluding a page that something links to would create dead anchors and red the gate — the check came first.The test asserts the resolved export, not the file text
tests/config.import.test.tsasserts the resolvedsrcExcludevalue rather than grepping the config source, because the explanatory comment in the file would satisfy atoContaincheck on its own and the test would pass with the setting deleted. Mutation-proven: removing the setting exits 1. Restored by file copy with matching md5.Gates
npm test0 (85 — the new test) ·npm run docs:build0 · 158 pages, 3474 links, 0 dead, matching the control.🤖 Generated with Claude Code