Skip to content

image croping for image type from bannerWidget too - #157

Open
ahsan-21 wants to merge 2 commits into
derhansen:mainfrom
ahsan-21:master
Open

ahsan-21 wants to merge 2 commits into
derhansen:mainfrom
ahsan-21:master

Conversation

@ahsan-21

@ahsan-21 ahsan-21 commented Oct 2, 2016

Copy link
Copy Markdown

image cropping for image type, also supported for bannerWidget too

@derhansen

Copy link
Copy Markdown
Owner

Thanks for your Pull-Request! I see some problems, when I have placed the plugin multiple times on the same page and want to use images with different sizes (e.g. 760 x 80 for one banner and 400 x 300 for another banner).

Could you explain, in which situations the image cropping is needed? I'll try to find a solution, which suits all needs without breaking existing functionality.

@ahsan-21

ahsan-21 commented Oct 3, 2016

Copy link
Copy Markdown
Author

i was adding multiple bannerWidget through typoscript and i want different banners with different sizes. here is a sample TS code

lib.bannerRightData < plugin.tx_sfbanners.widgets.bannerWidget
lib.bannerRightData.settings {
displayMode = all
startingPoint = 61
imgCrop = 1
imgWidth = 185c
imgHeight =
category=2
}

@ahsan-21

ahsan-21 commented Oct 3, 2016

Copy link
Copy Markdown
Author

and i also have 3 different sizes banner widgets running on my page

@derhansen

Copy link
Copy Markdown
Owner

Thanks again! I'm currently very busy, so it may take some time for me to merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants