Repository navigation
Conversation
On a Qualcomm phone the GNSS engine runs in the modem and answers QMI LOC over QRTR, and its own NMEA is only the proprietary $PQ sentences, which ModemManager's gps-nmea and GeoClue's modem source can't use. The new omamobile-gnss-qmi-loc opens a LOC client, runs a periodic session and writes GGA, RMC, GSA and GSV into /run/omamobile-gnss/nmea_out, which the existing bridge serves to GeoClue as it does the Pixels' FIFOs. It runs only on a phone whose device package ships /usr/share/omamobile/gnss/qmi-loc.conf: omamobile-gnss-start execs it then, and omamobile-gnss.service gains that file as a third alternative condition. Without the file every path is the Pixels' as before; the bridge's FIFO list and its start wait only gain the new FIFO at the end. ENGINE_UNLOCK=1 clears an engine lock the stock system left in the modem's EFS (QMI error 46 on every start). It is a LOC request, so the modem writes its EFS; the OnePlus 7T Pro's rmtfs keeps those writes in RAM (rmtfs -r), and a device without that must leave it off. On the OnePlus 7T Pro (device/hotdog/GNSS-PLAN.md G0-G5, 2026-11-15, 7.3.0-rc6-omamobile-push1 builds of its port): outdoors, the first fix 52 s after the request (10 satellites used, 36 tracked), and GeoClue's where-am-i got it. test/all passes on the laptop, with new tests for the QMI LOC path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
omamobile-gnss 0.2.11: a Qualcomm modem's GNSS over QMI LOC, for the OnePlus 7T Pro (#931,
device/hotdog/GNSS-PLAN.md).The modem's engine answers QMI LOC over QRTR, and its own NMEA is only the proprietary
$PQsentences. The newomamobile-gnss-qmi-locdoes three things:/run/omamobile-gnss/nmea_out;Inert on every other phone. It runs only where the device package ships
/usr/share/omamobile/gnss/qmi-loc.conf. Without that file:omamobile-gnss.serviceonly gains the file as a third alternative condition.ENGINE_UNLOCK=1clears an engine lock that stock left in the modem's EFS (QMI error 46). It is a LOC request, so the modem writes its own EFS. On hotdog, rmtfs runs read-only (-r) and keeps those writes in RAM. The daemon's doc says a device without that must leave it off.Device and build
uname -r):7.3.0-rc6-omamobile-push1-g7539ca3e06f6Checks (no phone needed)
tools/pr-check origin/mainpassestests/packages: the touched package'stest/allpasses (omamobile-gnss, with new tests for the QMI LOC path)versionbumped, and the new version is in the commit subjectCo-Authored-By:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspaceThe phone-smoke report from the OnePlus 7T Pro, running the port's branch, is in #931.
🤖 Generated with Claude Code