Repository navigation
Conversation
…int light What the OnePlus 7T Pro needs from the shell, each part inert on every other phone: - Mobile data and the Mobile network page through ModemManager and NetworkManager on a phone without omamobile-modem-sit (its modem is qcom-soc over QRTR): the status from ModemManager's objects, data as a NetworkManager gsm profile owned by the user, "auto" APN = the network's initial EPS bearer APN, never empty. Only where the device package ships /usr/share/omamobile/mobile-network-modemmanager; elsewhere the page and the tile read "No modem" as before, and the helper is never asked (device/hotdog/MODEM-PLAN.md). - omamobile-call-proximity: the screen off at the ear in earpiece calls (panel off, touchscreen grabbed), from an SW_FRONT_PROXIMITY switch or iio-sensor-proxy. Only where the device package ships /usr/share/omamobile/call-proximity: the unit's ConditionPathExists and the tool both check it, so the Pixels' calls are unchanged (device/hotdog/SENSORS-PLAN.md). omamobile-keys dark-unlocked leaves the phone unlocked only while that tool has the panel off for the ear. - The fingerprint light for an optical sensor without LHBM: a white disc under the finger, drawn only when the bridge's state says "illuminate": true, which no Pixel bridge writes (device/hotdog/FINGERPRINT-PLAN.md). - omamobile-sleepd lights the lock screen after a wake by a Qualcomm PMIC's power key (IRQ pm8941_pwrkey), beside KEY_POWER and Power. test/all passes on the laptop (dbus-run-session hidden from PATH, as without python-dbus); new tests check each opt-in both ways. Ran on the OnePlus 7T Pro as 0.2.135 of the port's branch (real calls with the ear blanking, mobile data from quick settings, fingerprint unlock); the opt-in gates are new here and not yet run on a phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
What the OnePlus 7T Pro (#931) needs from omamobile-shell 0.2.136. Each part is inert on every other phone:
omamobile-modem-sit(its modem is qcom-soc over QRTR). Data is a NetworkManager gsm profile owned by the user. "auto" APN means the network's initial EPS bearer APN, never an empty one, which crashed ModemManager 1.24.2./usr/share/omamobile/mobile-network-modemmanager, shipped by the device package. Without it the page and tile read "No modem" as before, and the helper is never asked (the OnePlus 13 also runs ModemManager without sit, and stays as it is).omamobile-call-proximity: the screen off at the ear in earpiece calls. The panel goes off and the touchscreen is grabbed, from anSW_FRONT_PROXIMITYswitch or iio-sensor-proxy./usr/share/omamobile/call-proximity, checked by both the unit'sConditionPathExistsand the tool. Pixel calls are unchanged.omamobile-keys dark-unlockedkeeps the phone unlocked only while that tool has the panel off for the ear."illuminate": true, which no Pixel bridge writes.omamobile-sleepdalso lights the lock screen after a wake by a Qualcomm PMIC power key (pm8941_pwrkey). Pixel IRQ names don't match it.Plans:
device/hotdog/MODEM-PLAN.md,SENSORS-PLAN.md,FINGERPRINT-PLAN.md(in #931). The opt-in files ship in #931's device-hotdog 0.1.19.Device and build
uname -r):7.3.0-rc6-omamobile-push1-g7539ca3e06f6Checks (no phone needed)
tools/pr-check origin/mainpassestests/packages: the touched package'stest/allpasses (omamobile-shell; on this laptop withdbus-run-sessionhidden from PATH for lack of python-dbus)versionbumped, and the new version is in the commit subjectCo-Authored-By:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspaceThe phone-smoke report from the OnePlus 7T Pro, running the port's branch, is in #931.
🤖 Generated with Claude Code