Skip to content

omamobile-shell 0.2.136: the OnePlus 7T Pro's modem, ear and fingerprint light (opt-in) - #932

Open
johannSo wants to merge 1 commit into
derekross:mainfrom
johannSo:hotdog-shell
Open

johannSo wants to merge 1 commit into
derekross:mainfrom
johannSo:hotdog-shell

Conversation

@johannSo

Copy link
Copy Markdown

What and why

What the OnePlus 7T Pro (#931) needs from omamobile-shell 0.2.136. Each part is inert on every other phone:

  • Mobile data and the Mobile network page through ModemManager and NetworkManager, for a phone without omamobile-modem-sit (its modem is qcom-soc over QRTR). Data is a NetworkManager gsm profile owned by the user. "auto" APN means the network's initial EPS bearer APN, never an empty one, which crashed ModemManager 1.24.2.
    • Gate: /usr/share/omamobile/mobile-network-modemmanager, shipped by the device package. Without it the page and tile read "No modem" as before, and the helper is never asked (the OnePlus 13 also runs ModemManager without sit, and stays as it is).
  • omamobile-call-proximity: the screen off at the ear in earpiece calls. The panel goes off and the touchscreen is grabbed, from an SW_FRONT_PROXIMITY switch or iio-sensor-proxy.
    • Gate: /usr/share/omamobile/call-proximity, checked by both the unit's ConditionPathExists and the tool. Pixel calls are unchanged.
    • omamobile-keys dark-unlocked keeps the phone unlocked only while that tool has the panel off for the ear.
  • The fingerprint light for an optical sensor without LHBM: a white disc under the finger.
    • Gate: drawn only when the bridge's state says "illuminate": true, which no Pixel bridge writes.
  • omamobile-sleepd also lights the lock screen after a wake by a Qualcomm PMIC power key (pm8941_pwrkey). Pixel IRQ names don't match it.

Plans: device/hotdog/MODEM-PLAN.md, SENSORS-PLAN.md, FINGERPRINT-PLAN.md (in #931). The opt-in files ship in #931's device-hotdog 0.1.19.

Device and build

  • Phone: OnePlus 7T Pro (hotdog); none needed for the other phones (gated off)
  • Kernel release (uname -r): 7.3.0-rc6-omamobile-push1-g7539ca3e06f6
  • Packages changed, with versions: omamobile-shell 0.2.136

Checks (no phone needed)

  • tools/pr-check origin/main passes
  • tests/packages: the touched package's test/all passes (omamobile-shell; on this laptop with dbus-run-session hidden from PATH for lack of python-dbus)
  • Each changed package has its version bumped, and the new version is in the commit subject
  • Commits have area prefixes and bodies that say why; AI help is a Co-Authored-By: trailer, never a Signed-off-by:
  • New tests check each opt-in both ways (tile-scripts.sh, mobile-network.py, call-proximity.py)

On the phone

  • I ran this on my own phone as the port's 0.2.135: real calls with the ear blanking, mobile data from quick settings, fingerprint unlock with the light
  • What I did not test: the opt-in gates themselves on a phone (new in this PR); any Pixel
  • Nothing in this change writes outside slot B and userdata, weakens the storage guard, or reads registers from userspace

The phone-smoke report from the OnePlus 7T Pro, running the port's branch, is in #931.

🤖 Generated with Claude Code

…int light

What the OnePlus 7T Pro needs from the shell, each part inert on every
other phone:

- Mobile data and the Mobile network page through ModemManager and
  NetworkManager on a phone without omamobile-modem-sit (its modem is
  qcom-soc over QRTR): the status from ModemManager's objects, data as a
  NetworkManager gsm profile owned by the user, "auto" APN = the network's
  initial EPS bearer APN, never empty. Only where the device package
  ships /usr/share/omamobile/mobile-network-modemmanager; elsewhere the
  page and the tile read "No modem" as before, and the helper is never
  asked (device/hotdog/MODEM-PLAN.md).
- omamobile-call-proximity: the screen off at the ear in earpiece calls
  (panel off, touchscreen grabbed), from an SW_FRONT_PROXIMITY switch or
  iio-sensor-proxy. Only where the device package ships
  /usr/share/omamobile/call-proximity: the unit's ConditionPathExists and
  the tool both check it, so the Pixels' calls are unchanged
  (device/hotdog/SENSORS-PLAN.md). omamobile-keys dark-unlocked leaves
  the phone unlocked only while that tool has the panel off for the ear.
- The fingerprint light for an optical sensor without LHBM: a white disc
  under the finger, drawn only when the bridge's state says
  "illuminate": true, which no Pixel bridge writes
  (device/hotdog/FINGERPRINT-PLAN.md).
- omamobile-sleepd lights the lock screen after a wake by a Qualcomm
  PMIC's power key (IRQ pm8941_pwrkey), beside KEY_POWER and Power.

test/all passes on the laptop (dbus-run-session hidden from PATH, as
without python-dbus); new tests check each opt-in both ways. Ran on the
OnePlus 7T Pro as 0.2.135 of the port's branch (real calls with the ear
blanking, mobile data from quick settings, fingerprint unlock); the
opt-in gates are new here and not yet run on a phone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant