Repository navigation
phone-smoke: limit whole-disk guard to RAM-only devices - #916
Open
quatrixone wants to merge 1 commit into
Open
quatrixone wants to merge 1 commit into
quatrixone wants to merge 1 commit into
Conversation
Keep the existing active-slot allowlist for Pixel devices. Use the\nwhole-disk read-only check only for descriptors with empty UFS_RW.\n\nTest both Pixel slots with the descriptor naming slot B, plus the\nDipper RAM-only disk and partition cases.\n\nAI assistance: Codex. Signed-off-by: quatrixone <quatrix1@gmail.com>
quatrixone
added a commit
to quatrixone/omarchy-mobile
that referenced
this pull request
Nov 18, 2026
Move Dipper RAM-only whole-disk checks to derekross#916 so this PR no longer changes the shared Pixel smoke path. AI assistance: Codex. Signed-off-by: quatrixone <quatrix1@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the existing Pixel storage guard and active-slot allowance unchanged.
Apply the whole-disk read-only check only when the installed device
descriptor explicitly has an empty UFS_RW list, as Dipper's RAM-only
descriptor does.
The fixtures cover Pixel slot A and B with a descriptor listing slot B,
plus Dipper's whole-disk and partition read-only checks.
Checks: tests/phone-smoke, tests/all, tools/pr-check origin/main.
No on-device run was done; this PR only changes the shared smoke check and
its fixtures. Dipper remains in draft #714 pending the required clean boot
and device evidence.