Repository navigation
Conversation
The maintainer's note on derekross#831 asked for this in a later docs pass: the docs list what tools/stage-boot-files refuses (SSH keys, host keys, another device's allowlist) but not the development boot policies it has refused since derekross#831. That list is in §5.5's stage-boot-files bullet (§5.3 doesn't name the tool), so this adds them there, with the archive rule the tool applies. No other line in RELEASES.md lists what the staging refuses. Docs only. Tested: tools/stage-boot-files on four lz4 cpio archives built as tests/stage-boot-files builds them (cheetah's allowlist, this tree's init), before and after: the release one stages, the three with a policy file are refused, as the new sentence says. tests/stage-boot-files (which covers these refusals since derekross#831) and tools/pr-check origin/main pass in a sandbox without network. tests/all passes in that sandbox with tests/extract-vendor-firmware left out (its two real-ext4 cases fail in a user namespace, on the base too), and that suite passes on its own outside the sandbox. Not tested: nothing here runs on a phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
docs/RELEASES.mdlists whattools/stage-boot-filesrefuses in a release initramfs: the builder's SSH keys, dropbear host keys and another device's allowlist. Since #831 the tool also refuses a development boot policy, and the list didn't say so. This is the docs pass invited in the merge note on #831. The note names §5.3; the list is in §5.5'stools/stage-boot-filesentry (§5.3 doesn't mention the tool), so I changed it there.The entry now states the rule the tool applies to the archive, with the names its messages use: any
etc/omamobile-nfsroot(OMAMOBILE_NFSROOT) oretc/omamobile-root-mode(INITRAMFS_ROOT_MODE) is refused, and so is anetc/omamobile-usb-recovery(INITRAMFS_USB_RECOVERY) that is not one file sayingyes. No other line in the file lists what the staging refuses. One line changes; no tool or test does.tests/stage-boot-fileshas covered these refusals since #831.I had AI agents run the checks below on an x86_64 desktop. The block below shows the documentation sentence and the real staging tool on four archives at
fe6fab42anddeb648ce.Device and build
uname -r): no phoneChecks (no phone needed)
tools/pr-check origin/mainpasses (AI agent)tests/allpasses (AI agents ran every suite and all passed, one of them outside the sandbox; see below)tests/packagespasses (or the packages I touched: none, so not run)versionbumped, and the new version is in the commit subject: no package changedCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: a docs change that never runs on a phone (CONTRIBUTING.md §6.5).
On deb648ce, under
bwrap --unshare-netwith adockerstub that exits 1:tools/pr-check origin/mainandtests/stage-boot-filespassed, andtests/allpassed through its last suite withtests/extract-vendor-firmwareleft out. That suite fails two "real ext4" cases in the sandbox's user namespace on the base too (debugfsgets EINVAL fromchown); it names no URL and passed on its own outside the sandbox.Setup: Ubuntu 26.04 on x86_64, bash 5.3.9, GNU cpio 2.15, lz4 1.10.0, no network; each commit's checkout; four initramfs archives built as
tests/stage-boot-filesbuilds them (cheetah's allowlist, the tree'sinit), with that test's stand-in fordtcandmkdtboimg.Steps: print the §5.5 sentence → for each archive, run
DEVICE=cheetah tools/stage-boot-fileson it → print the output and exit statusBefore, on fe6fab42, run before the change was written:
After, on deb648ce:
AI agents repeated the steps on the tree of main at 143f2ce7, whose only change from
fe6fab42is.github/workflows/checks.yml, and on its cleangit merge-treeresult withdeb648ce(treed144f063). The transcripts match the corresponding runs above apart from the reported HEAD SHA and the scratch directory name.Links: the commit deb648ce; the refusals' test in
tests/stage-boot-files; the invite on #831.Not shown:
tools/phone-smoke). This change only edits documentation.tests/packages). No package changed.bin/omamobile initramfs --releasebuild. This docs change covers staging, which the checks exercised with local archive fixtures.tests/allrun:tests/extract-vendor-firmwareran on its own outside the sandbox, as above.tests/allskipped on this machine: Docker end-to-end provisioning, two AOSP boot-image checks, SVE execution and the root-image smoke test.Generated with Claude Opus 5.5 in T3 Code Nightly