Repository navigation
Conversation
derekross
left a comment
There was a problem hiding this comment.
Thank you, Lef. This is a real improvement to a sheet people stare at for ten minutes, and the description says exactly what you saw and what you haven't tried. I read the change and built a small Qt test around your Flickable handlers (same Qt as the phones, 6.12): it opens at the newest line, follows new lines and the live bar line, stays put after a scroll up while lines arrive, and follows again after reopening. So the logic holds.
Before it goes in:
- A run on your phone. It changes the update sheet on every phone and so far it has only been rendered. With the shell installed from this branch, one update that downloads something: the progress line during the download, Details open with the bar line last and moving, a scroll up that stays where you left it, a scroll back to the end that follows again, the result page with Details collapsed, and closing and reopening the sheet mid-run. Plus
tools/phone-smoke. Please also watch whether the Details box jumps up and down when the progress line switches between one line and two or three (it's anchored under that text); if it does, reserving three lines for the text would stop it. - Please take the two PNGs out of the commit and attach them to the PR instead. Nothing in
docs/refers to them, and a squash would keep them in the repository for good. I looked at both: nothing identifying in them.
Two small things, neither blocking: reopening the sheet during a run opens Details again even if you had closed it (followEvents() sets it every time); and with Details open by default the whole list is laid out again on every progress event, so have a look at top during a download.
Six other open PRs also say omamobile-shell 0.2.134, so I'll set the number when I merge. CI passes, but note it doesn't draw the sheet (test/update-render only runs with OMAMOBILE_UPDATE_RENDER set), so your render run and the phone run are the evidence.
0dc5204 to
9e0e3c6
Compare
|
@derekross thanks for the review and for building the Qt test around it. Fixed on the branch:
|
…ines and shows pacman's live line On the phone the progress line was one elided line, so pacman's download bar was cut after the package name, and Details opened on the oldest of up to 400 lines and never showed the download (the \r bar line is a progress event, not a log line), so during a long download it looked stuck. Now: - the progress line wraps to at most 3 lines, with pacman's padding squeezed - Details shows the live bar line after the log lines - Details opens on the newest lines and follows new ones, unless the user scrolled up (until they scroll back to the end) - Details is open on the progress page and collapsed on the result page test/update-render gets a portrait progress shot with Details open.
…s closed when you close it during a run
9e0e3c6 to
15ba4ae
Compare
Ran the Omarchy update on my Pixel 8 Pro today (4.0.6 to 4.5.0, about 1.3 GB) and the sheet was hard to follow. The progress line is a single elided line, so pacman's download bar got cut right after the package name, and the rest of the sheet was empty. Opening Details didn't help much: it opens on the oldest of up to 400 lines, and during a download nothing new shows there at all, because pacman's bar is a
\rprogress event and never becomes a log line. With a 7 minute chromium download it looked stuck.How it looked on the phone:
What this changes in
omamobile.update/Update.qml:This is the render test with Details open, made-up lines and a long bar line (not a phone shot, the phone still has the old sheet):
Testing:
test/update-rendergets a portrait progress shot with Details open (6 shots per theme now) and passes all its checks in tokyo-night and catppuccin-latte in the OWL container.test/allfor omamobile-shell passes. I haven't run it on the phone yet, so the following-while-scrolling part is only read from the code, not tried with a finger. Bumped omamobile-shell to 0.2.134.