Skip to content

tests/install-slot-descriptor: runs on a computer without fastboot, and a failure says why - #893

Merged
derekross merged 1 commit into
mainfrom
tests-slot-descriptor-no-fastboot
Nov 18, 2026
Merged

derekross merged 1 commit into
mainfrom
tests-slot-descriptor-no-fastboot

Conversation

@derekross

Copy link
Copy Markdown
Owner

@only21mil reported on #882 and #884 that tests/install-slot-descriptor stops tests/all on a computer without fastboot.

  • Cause: tools/install-phone checks for its programs before it reads the two descriptor keys the suite is about. The suite never runs any of them: it stops at the missing images.
  • Fix: a stand-in at the end of PATH answers command -v for whichever of the installer's programs is missing. A real program always wins, and the suite fails if a stand-in is ever run.
  • Also: the failure printed only cat: …/o.installer: No such file, because the installer's output went to o.install while the report read o.<reader>. Renamed, so a failure now shows the installer's error and the not ok line.

Checked with FASTBOOT=zz-no-fastboot: main's suite exits 1, this one passes; with the stand-ins switched off it fails with the installer's own message.

🤖 Generated with Claude Code

…nd a failure says why

install-phone checks for its programs before it reads INSTALL_SLOT, so on
a computer without one of them (fastboot, on a machine that installs no
phone) the suite stopped tests/all; only21mil reported it on #882 and
#884. The suite stops at the missing images long before any of them
runs, so a stand-in at the end of PATH now answers `command -v` for
whatever is missing; a real program always wins, and a stand-in that is
ever run fails the suite.

The failure itself printed only "cat: .../o.installer: No such file":
the installer's output went to o.install while the report read
o.<reader>, and under set -e the cat ended the suite before its message.
The file is now o.installer, and the same case with the stand-ins off
prints the installer's own error and the "not ok" line.

Checked with FASTBOOT=zz-no-fastboot: main's suite exits 1, this one
passes.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit b9b6844 into main Nov 18, 2026
2 checks passed
@derekross
derekross deleted the tests-slot-descriptor-no-fastboot branch November 18, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant