Repository navigation
tests/install-slot-descriptor: runs on a computer without fastboot, and a failure says why - #893
Merged
Merged
Conversation
…nd a failure says why install-phone checks for its programs before it reads INSTALL_SLOT, so on a computer without one of them (fastboot, on a machine that installs no phone) the suite stopped tests/all; only21mil reported it on #882 and #884. The suite stops at the missing images long before any of them runs, so a stand-in at the end of PATH now answers `command -v` for whatever is missing; a real program always wins, and a stand-in that is ever run fails the suite. The failure itself printed only "cat: .../o.installer: No such file": the installer's output went to o.install while the report read o.<reader>, and under set -e the cat ended the suite before its message. The file is now o.installer, and the same case with the stand-ins off prints the installer's own error and the "not ok" line. Checked with FASTBOOT=zz-no-fastboot: main's suite exits 1, this one passes. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@only21mil reported on #882 and #884 that
tests/install-slot-descriptorstopstests/allon a computer withoutfastboot.tools/install-phonechecks for its programs before it reads the two descriptor keys the suite is about. The suite never runs any of them: it stops at the missing images.PATHanswerscommand -vfor whichever of the installer's programs is missing. A real program always wins, and the suite fails if a stand-in is ever run.cat: …/o.installer: No such file, because the installer's output went too.installwhile the report reado.<reader>. Renamed, so a failure now shows the installer's error and thenot okline.Checked with
FASTBOOT=zz-no-fastboot: main's suite exits 1, this one passes; with the stand-ins switched off it fails with the installer's own message.🤖 Generated with Claude Code