Repository navigation
Conversation
|
Thank you, Lef. The blind rounds are the right way to pick numbers by eye, the pcall around It can't go in yet, for these reasons:
Smaller:
On the numbers: #836 merges first as 0.1.15, and this keeps 0.1.17. It conflicts with #836 in |
A Hyprland screen shader, pow(rgb, 1.55) then x0.88, from blind rounds by eye on the 8 Pro's panel. The cause of the flat mid-tones is unknown, so this is a stopgap. It is set from /usr/share/omamobile/hypr/device.lua, which the phone.lua hook from derekross#204 loads; this depends on derekross#204. It is off by default: ~/.config/omamobile/screen-look-on turns it on, and without it device.lua doesn't call hl.config. glslang and lua become checkdepends for the test.
8db9aa6 to
12ad95d
Compare
|
@derekross thanks for checking the Hyprland side, and for answering the capture question. Done in 12ad95d, rebased on main with #836 in (test/all keeps both blocks, version stays 0.1.17):
I rewrote the description for opt-in too. Still waiting on #204, and then I'll do the package run with your list (versions, |
derekross
left a comment
There was a problem hiding this comment.
Thank you, Lef. Every point is done, and I checked each in the code: the look is off unless ~/.config/omamobile/screen-look-on is there, and without it device.lua doesn't call hl.config at all; the header check no longer pipes into grep -q; the loop only looks for another package shipping your shader file; the README has the capture note and the Wi-Fi sentence. I ran the suite here and broke device.lua twice (calling hl.config without the marker, and without the pcall), and your new cases caught both.
The check is still red, and it isn't yours: CI has no glslang and no lua, so your test stops at "glslangValidator (glslang) is installed for the shader check", as I said it would. Every other suite in that run passed. I'll add the two packages to the workflow and re-run.
What's left, in order:
- I add
glslangandluato CI. - #204 merges.
- Your run from the package, with the list from my last comment (versions,
getoptionafter login, with the marker and a reload, after removing it, the session log, screen off and on, the lock screen,tools/phone-smoke).
On the number: #899 and #860 also bump this package, so I'll set the version when I merge, whichever comes first. Nothing for you to do about it.
omamobile-device-husky's coming test (#880) checks a shader with glslangValidator and stops without it, and the Lua cases of package tests were skipped on CI for want of an interpreter. Both are in Arch's extra repository. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
@derekross, @Somnius, tried by hand on my unit: the It looks better to me. I only tried 1.55 with 0.88, no other values, and I have no stock phone beside it. I'm leaving it on for now and will say if it ever looks too dark. |
|
@gitColinX thanks for trying it by hand. That's a second unit where it looks better, even if neither of us has a stock phone beside it to compare. Good to hear it applied live on 4.0.6 too. If it ever looks too dark on yours, please say so here. |
omamobile-device-husky 0.1.17: screen look stopgap for the 8 Pro (#537)
This ships the screen shader I've been running on my 8 Pro since 11-14, for the picture looking washed out after boot. It's off by default and one file turns it on. It's
pow(rgb, 1.55)then times 0.88, as a Hyprland screen shader.It depends on #204 (#204). That PR adds the optional
/usr/share/omamobile/hypr/device.luahook tophone.lua, loaded withpcallafter the shared rules. This PR only adds husky's owndevice.luaand the shader, no shell changes, so without #204 the file is installed but nothing loads it. Insidedevice.luathehl.configcall is in apcalltoo and prints an error if it fails.The numbers come from a first pass with the names showing, then two blind gamma rounds and one blind gain round by eye on the panel. Gamma 1.5 to 1.6 won the blind gamma rounds, no change looked washed out, more saturation looked worse, and the gain round picked 0.85 to 0.92, so 0.88. Details and the correction are here:
#537 (comment)
#537 (comment)
#537 (comment)
The cause is still unknown. Stock's tables don't explain a curve like this, and @gitColinX saw his unit look deeper for a while on 11-15 with nothing changed, so panels or the panel state after the bootloader may differ. So this is a stopgap, the real fix belongs in the display path.
To turn it on:
touch ~/.config/omamobile/screen-look-onandhyprctl reload. Remove the file and reload to turn it off. Without the filedevice.luadoesn't callhl.configat all, so ascreen_shaderline in the user's own config still applies, and nothing changes for anyone who doesn't create it. My own phone has the shader inlooknfeel.lua, which is how I've been running it since 11-14.Screenshots, recordings and the VNC mirror don't show the shader: they go through Hyprland's screencopy, and v0.57.0's
ScreenshareFrame.cppsetsblockScreenShaderfor its frames. So the look can only be judged on the panel or with a camera.Husky goes to 0.1.17 (#836 is in as 0.1.15, #860 has 0.1.16). The README also says now that an updated phone gets #836's Wi-Fi power save from its next boot. glslang and lua are now checkdepends, and the test fails if they're missing instead of skipping.
Tested: husky's
test/allandtools/pr-checkpass. The test checks the GLSL ES header, compiles the shader with glslangValidator, runsdevice.luawith a stubhlwith and without the marker (no marker means nohl.configcall at all) and with a failinghl.config, and checks no other device package shipsscreen-look.frag. The shader itself, same file, has been live on my phone since 11-14 and the GPU stayed at its lowest clock with it on.Not tested: I haven't built and installed the package on the phone, so install from the package and the load through #204's hook aren't tried in a real session. Turning it on and off with the marker and
hyprctl reloadisn't tried on the phone either. And it's only tried on my unit, which is why it's opt-in.