Repository navigation
Conversation
|
Thanks for this, and for the three beside it. I checked both pins against their sources rather than take them from the description: One change, please. On the container: the job still runs Two notes for the merge, nothing for you to do: #690 adds Your run was waiting for my approval as a first contribution; I'll approve it once the v5.1.0 pin is in. |
…tainer to its digest Supply-chain hardening from the 2026-11-16 security audit (S-1): tag-pinned actions and a floating container image are the two CI inputs that can move under a PR without any code change. Pin the action to the v5.1.0 commit (fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09, what @v5 resolves to today) and the container to the image index digest resolved on 2026-11-16 (the amd64 image inside is from 2026-11-09); bump the digest deliberately to update, and refresh archlinux-keyring first so an older base can still verify a newer packager key. Assisted-By: pi coding agent (adversarial audit, 2026-11-16)
derekross
left a comment
There was a problem hiding this comment.
Your run has been approved and it is green on this head, both jobs, so the pinned checkout commit and the pinned container digest both work in practice. I re-checked the two values against GitHub and Docker Hub again today and they are still genuine.
The one thing still open is the release: v5 in actions/checkout points at v5.1.0 (fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09), so pinning v5.0.0 moves CI back a release. Could you change the four uses: lines to that commit, with the comment # actions/checkout v5.1.0? If you'd rather not come back to it, say so and I'll push that change to your branch myself.
The keyring refresh before pacman -Syu and the digest-reading command in the comment are still welcome in the same push, but I won't hold the merge for them.
5414140 to
ad4f416
Compare
|
Reworked: all four pins are now actions/checkout v5.1.0 (fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 — verified against refs/tags/v5.1.0), the container comment names the imagetools command and dates both the index resolution (2026-11-16) and the inner image (2026-11-09), and archlinux-keyring is refreshed before the -Syu. The kernel-repo copy carries the same action pins. Rebased onto current main (c462357) so the #690 fetch-depth overlap can be seen directly. |
Supply-chain hardening (audit round 2, 2026-11-16, finding S-1).
The two CI inputs that can move under a PR without any code change:
actions/checkout@v5-> pinned to v5.0.0 commit08c6903cd8c0fde910a37f88322edcfb5dd907a8(.github/workflows/checks.yml,ci/linux-omarchy-mobile/checks.yml).container: archlinux:latest-> pinned to the 2026-11-16 amd64 digestsha256:d4594bb2…. Bump the digest deliberately to update.Both workflows keep their current behavior; tags/SHAs verified against the GitHub API today.