Repository navigation
device-panther: the default calibration's evidence and its omamobile-audio - #812
angelrenefm wants to merge 2 commits into
Conversation
|
Thank you, Ángel, for coming back to both points from #496: the drop-in now points at your 15:33 report, where the start and the playback are, and the One thing I need from you, since I can't push to your fork: the package's |
b248ad1 to
3f35528
Compare
|
Thank you, Ángel. You did exactly what I asked: rebased onto #577 with both README rows kept, and the version at 0.1.17. The package test passes here on your head, also together with #827. And then I got in your way: a few hours after I asked you for 0.1.17, I asked Alejandro for the same number on #827 (the charger's policy), which has to go in first because the kernel's charger node waits for it. That's my mistake, not yours. Once #827 is merged, could you set |
…audio Two follow-ups from derekross#496's review. The drop-in cited the 16:13 comment on derekross#427; the start and the playback are in the 15:33 one. And device-panther doesn't depend on omamobile-audio, so with one older than 0.5.16 the setting does nothing and the speakers stay muted: an optdepends line and a sentence in the README and the drop-in say so. The package's test/all passes (19 ok). Version left for the merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross#827 took 0.1.17 first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3f35528 to
d3ce644
Compare
|
Thank you, Derek, no harm done. With #827 merged, 0.1.17→0.1.18 on top didn't merge cleanly against main (both changed the same line from 0.1.16), so I rebased onto main: the first commit is unchanged apart from the version line now coming from main, and the version is 0.1.18 in a commit of its own. I used AI help (Claude) to work on this. |
The two follow-ups from #496's review: the drop-in cites the 15:33 comment on #427 (where the start and the playback
are), and since device-panther doesn't depend on omamobile-audio, an
optdependsline and a sentence in the README andthe drop-in say that with one older than 0.5.16 the setting does nothing and the speakers stay muted. The package's
test/allpasses. I left the version for the merge.I used AI help (Claude) to work on this.