Skip to content

device-panther: the default calibration's evidence and its omamobile-audio - #812

Open
angelrenefm wants to merge 2 commits into
derekross:mainfrom
angelrenefm:panther-speaker-cal-notes
Open

angelrenefm wants to merge 2 commits into
derekross:mainfrom
angelrenefm:panther-speaker-cal-notes

Conversation

@angelrenefm

Copy link
Copy Markdown
Contributor

The two follow-ups from #496's review: the drop-in cites the 15:33 comment on #427 (where the start and the playback
are), and since device-panther doesn't depend on omamobile-audio, an optdepends line and a sentence in the README and
the drop-in say that with one older than 0.5.16 the setting does nothing and the speakers stay muted. The package's
test/all passes. I left the version for the merge.

I used AI help (Claude) to work on this.

@derekross

Copy link
Copy Markdown
Owner

Thank you, Ángel, for coming back to both points from #496: the drop-in now points at your 15:33 report, where the start and the playback are, and the optdepends line and the README sentence say plainly what an older omamobile-audio does.

One thing I need from you, since I can't push to your fork: the package's version. The drop-in is installed, so the package needs a new number. #577 is about to take 0.1.16, so once #577 has merged, could you rebase this onto main (the README rows from both PRs sit next to each other; keep both) and set packages/omamobile-device-panther/version to 0.1.17? If anything else takes 0.1.17 first I'll tell you the next free one. Then I'll merge it.

@angelrenefm
angelrenefm force-pushed the panther-speaker-cal-notes branch from b248ad1 to 3f35528 Compare November 17, 2026 19:24
@derekross

Copy link
Copy Markdown
Owner

Thank you, Ángel. You did exactly what I asked: rebased onto #577 with both README rows kept, and the version at 0.1.17. The package test passes here on your head, also together with #827.

And then I got in your way: a few hours after I asked you for 0.1.17, I asked Alejandro for the same number on #827 (the charger's policy), which has to go in first because the kernel's charger node waits for it. That's my mistake, not yours. Once #827 is merged, could you set packages/omamobile-device-panther/version to 0.1.18, as one more commit on top (no rebase needed, the two merge cleanly)? If you'd rather not, say so and I'll push that one line to your branch myself. Then CI runs and I merge it.

angelrenefm and others added 2 commits November 18, 2026 07:26
…audio

Two follow-ups from derekross#496's review. The drop-in cited the 16:13 comment
on derekross#427; the start and the playback are in the 15:33 one. And
device-panther doesn't depend on omamobile-audio, so with one older
than 0.5.16 the setting does nothing and the speakers stay muted: an
optdepends line and a sentence in the README and the drop-in say so.

The package's test/all passes (19 ok). Version left for the merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross#827 took 0.1.17 first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@angelrenefm
angelrenefm force-pushed the panther-speaker-cal-notes branch from 3f35528 to d3ce644 Compare November 18, 2026 18:09
@angelrenefm

Copy link
Copy Markdown
Contributor Author

Thank you, Derek, no harm done. With #827 merged, 0.1.17→0.1.18 on top didn't merge cleanly against main (both changed the same line from 0.1.16), so I rebased onto main: the first commit is unchanged apart from the version line now coming from main, and the version is 0.1.18 in a commit of its own.

I used AI help (Claude) to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants