Skip to content

device/panther: an opt-in overlay for the MFC (hardware video) - #811

Merged
derekross merged 1 commit into
derekross:mainfrom
angelrenefm:panther-mfc-overlay
Nov 15, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
angelrenefm:panther-mfc-overlay

Conversation

@angelrenefm

Copy link
Copy Markdown
Contributor

The kernel describes the Pixel 7's MFC v15 but leaves it disabled (linux-omarchy-mobile#250), as you decided there:
its System MMUs are not described, so Google's closed firmware parsing untrusted video could reach all memory below
4 GiB. This adds the overlay that enables it, for an owner who accepts that:

  • device/panther/overlays/mfc.dtso: status = "okay" on /soc@0/video-codec@1c8d0000, by path, with the reason in
    its comment. Not added to DTB_OVERLAYS.
  • device/panther/NOTES.md: a dated entry with the decision, the firmware it needs (tools/extract-vendor-firmware,
    extract-vendor-firmware: the Pixel 7's video codec firmware #747) and what would turn it on by default (the iommus and S2MPU series).

Tested: compiled with the kernel build's dtc -@, and applied with fdtoverlay to gs201-panther.dtb from #250's
head: the node goes from disabled to okay, nothing else changes. Not tested: a boot with it through
omamobile-boot-update (it needs #250 merged and published first).

I used AI help (Claude) to work on this.

The kernel describes the Pixel 7's MFC v15 with its 256 MiB pool but
leaves it disabled (linux-omarchy-mobile#250): its System MMUs aren't
described, so Google's closed firmware, parsing untrusted video, could
reach all memory below 4 GiB. overlays/mfc.dtso enables it, by path, for
an owner who accepts that, with the reason in its comment; it isn't in
DTB_OVERLAYS. NOTES.md gets a dated entry with the decision, the
firmware it needs (tools/extract-vendor-firmware, derekross#747) and what would
turn it on by default (the iommus and S2MPU series).

Compiled with the kernel build's dtc -@ and applied with fdtoverlay to
gs201-panther.dtb from derekross#250's head: the node goes from disabled to okay,
nothing else changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, Ángel, that's the overlay I had in mind on #250: off unless the owner asks for it, with the reason in the file itself and in the notes, and the firmware's source next to it. I built the Pixel 7's DTB from #250's head and applied your overlay with the kernel's own fdtoverlay: exactly one line changes, the MFC's status, as you said.

One small thing. The notes entry and the overlay's comment say the kernel already describes the MFC, but that only becomes true when linux-omarchy-mobile#250 merges, and on today's kernel the overlay can't find the node, so bin/omamobile images would stop with an error. Could you say "#250 (in review)" there, and add that the overlay needs a kernel with it? If #250 merges first, I'll take this as it is right after. While you're there, one sentence on how to turn it on (adding mfc to DTB_OVERLAYS in your copy of device/panther/device.conf) would help whoever reads it.

@derekross
derekross merged commit 6c11752 into derekross:main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants