Repository navigation
omamobile-device-husky 0.1.14: one sleep state, so a refused sleep isn't tried twice (#619) - #806
Conversation
…n't tried twice (derekross#619) The Pixel 8 Pro's part of derekross#619, as derekross#654 did for the Pixel 9a: SuspendState=freeze in the sleep.conf drop-in. systemd's default is "mem standby freeze", written to /sys/power/state in turn until one is accepted. With mem_sleep at s2idle the second write is the same sleep again, so a sleep a driver refuses is tried twice. "freeze" and not "mem", because it stays suspend-to-idle whatever mem_sleep says. It applies to the 8 Pro: on my phone (omamobile-device-husky 0.1.9, 7.3.0-rc6-omamobile-push1-g596d44e5bd5e, mem_sleep_default=s2idle on the command line) /sys/power/mem_sleep reads "[s2idle] deep" and systemd-analyze cat-config systemd/sleep.conf shows MemorySleepMode=s2idle and no SuspendState line. A refused sleep has not been seen on the 8 Pro, and on the 9a one state alone did not save Wi-Fi, so this only removes the second try. test/all compared the settings with the Pixel 7 Pro's copy, which doesn't have the line yet. It now checks the file's own five settings, the way derekross#654 changed the 9a's test. README row updated. Version 0.1.14, one above main's 0.1.13. Tested on the desktop only: packages/omamobile-device-husky/test/all, tests/packages for the husky, akita, tegu and cheetah device packages, and tools/pr-check origin/main pass. Not run yet: the test derekross#619 asks for, one systemctl suspend on the phone with suspend_stats success up by one, fail unchanged and cat-config showing the line.
|
Thank you, Lef. This is the same change as the 9a's in #654, and it's right. With What it still needs is the one-sleep test I asked for on #619 for each device. Could you install this branch's package on your 8 Pro (
Your phone is on device-husky 0.1.9, which has no sleep drop-in at all, the state behind the 11-12 critical-battery suspend into On your other two husky changes: open them whenever you like. I set the versions at merge, so the numbers in the branches don't matter. |
|
Ran it this morning. I built the package from this branch on the phone itself (makepkg from One thing I found first: my phone had a hand copy at Then one
Also to be honest about the setup: the phone still has |
|
Thank you, Lef. That is exactly the test I asked for: the package from this branch at 0.1.14-1, The hand copy is worth remembering. A file in Merging this as 0.1.14. #836 uses the same number and touches the README row right above this one, so it will need a rebase onto main afterwards (keep both rows) and becomes 0.1.15; I'll say the rest there. |
From the review on derekross#835: - H1's status line and heading say what was not checked: touch, the display and a played haptic effect, carried into H2, whose Pass line now names them. - Section 2 names the one UFS line that is expected at resume (dme-set: attr-id 0x4021, the peer device ID ufs-exynos sets when the link comes back) and says any other UFS error is a stop. The recovery bullet, the stop conditions and H1's Pass line say the same. - Section 3's brcmfmac noise list has the two other lines the H0b run printed, which this kernel also prints at boot. - The two results say "attended"; the package versions are the ones the stages ran on (0.1.13) and will run on (0.1.14 or later, derekross#806); the H1 loop sleeps 25 s, as the run's script did, and the reconnect comment matches. - Section 2 says whose go-ahead a stage waits for. - Section 4 records systemd-analyze cat-config systemd/sleep.conf on this unit: no /etc/systemd/sleep.conf.d/, so nothing hides the package's drop-in. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This is husky's half of #619, the same change #654 made for tegu:
SuspendState=freezein the sleep config, so a refused sleep isn't tried a second time with another state. The 8 Pro only does s2idle (mem_sleep_default=s2idleis on its command line, and/sys/power/mem_sleepreads[s2idle] deepon my unit today), so freeze is the state it uses anyway.Husky's
test/allcompared its sleep settings with cheetah's, and cheetah has no such line, so as in #654 it now checks the file's own five settings. Version 0.1.14, which is main's 0.1.13 plus one.Tested: husky's
test/allandtools/pr-check origin/mainon the desktop; the new check fails if the line is removed, set tomemor if a setting is added. Not run: the on-phone test @derekross asked for on #619 (onesystemctl suspend,suspend_statssuccess +1, fail unchanged,systemd-analyze cat-configshowing the line). My 8 Pro hasomamobile-device-husky0.1.9 installed and I haven't put this on it yet. I've never seen a refused sleep on the 8 Pro (the Wi-Fi-5in #619 is the 9a's), so I can only say this matches what #654 does, not that it fixes something here. I'll run that sleep and post the result on #619.@derekross, one question: I have two other husky package changes waiting (Wi-Fi power save on by default, and the USB rescue loop). If this lands first as 0.1.14, I'll rebase them to the next free numbers.