Repository navigation
Conversation
The SDDM drop-in requires hardware and GPU services that the root-only runbook does not install. Omit it from the snapshot, install and undo lists, and limit the expected result to root checks, SSH and marker cleanup. Desktop readiness belongs to the separate hardware integration. Validation: both documented shell blocks parse with bash -n; tools/pr-check origin/main passes. No phone changes. Co-Authored-By: Codex <noreply@openai.com>
Owner
|
Thank you, Chris. This is just what I meant on #565. The drop-in is gone from the snapshot, the install and the undo alike, and the Expect now asks only for what these four files can deliver: the check, SSH and the cleared marker. I read both units again: the ready helper needs only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root-only bring-up instructions copied an SDDM drop-in that requires hardware/GPU units outside that installation set, while expecting a ready desktop. This follows the non-blocking review note on #565.
Exclude the SDDM drop-in consistently from snapshot, installation and undo. The root-only Expect covers its check, USB SSH and cleared pending marker; desktop readiness belongs to the separately staged hardware/GPU stack. The existing historical kernel pins and runtime files are unchanged.
Validation: policy passes, both README shell blocks parse with
bash -n, all three offline ready-helper cases pass, and the complete repositorytests/allsuite passes. Documentation only; no package/version, descriptor, phone operation or new runtime qualification is included.Fresh hosted CI run 43652745505 passes policy,
tests/alland every package suite on04b9471a640a1ece32af6e2795201c3629d8643e.