Repository navigation
extract-vendor-firmware: husky follow-ups from #722 - #746
Conversation
|
Thank you, Colin. All three follow-ups from #722 are in, and they're right: the 8 Pro's Bluetooth refusal now names the phone, every other device keeps its message as it was, and the new haptics case does what it should. I ran the test on main with this merged (all pass) and once with the CS40L26 check turned off in a copy of the tool, and only your new case failed, with its message. One thing before I merge, and it's because of your other pull request: #752 gives the 8 Pro its address step, and I'm merging it first. After that, the README's last paragraph here ("Until this package has its own Bluetooth address step…") would say the opposite of the package. Could you drop it, or turn it into "pairings made before 0.1.13 have to be made again once", as you offered on #752? While you're in that file, "The kernel side is kernel #156 (a draft)" is out of date: #156 was closed, and the 8 Pro's Wi-Fi landed through kernel #187 on 11-09. On older factory builds: yes, if you can, run the tool on one or two older husky builds and post just the |
Derek's review of derekross#722 asked for three small things: - The refusal named the pattern ("is not a G5SN_V[0-9]*_HK3 Bluetooth patch"). BT_NAME gives it a readable name where BT_CHIP is a pattern: "BCM.hcd is not a Pixel 8 Pro (G5SN_V<n>_HK3) Bluetooth patch". Other devices keep their chip name. - No test fed husky a wrong cs40l26.wmfw. A Halo WMFW that isn't the CS40L26's is now refused for husky; with husky taken out of the haptics check, that test fails. - The device README said "also" before the Wi-Fi paragraph it referred to. The sentence follows it now, with a line that pairings made on the placeholder Bluetooth address won't survive the address step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross#752 gave the package its Bluetooth address step, so the paragraph that said a pairing wouldn't survive "until this package has its own address step" now says that pairings made before 0.1.13 have to be made again once. The Wi-Fi line named kernel derekross#156 as a draft; it merged through kernel derekross#187 on 2026-11-09. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4008840 to
e0afef7
Compare
|
@derekross, both done in a new commit, on today's
The package test and On older factory builds: thank you, I'll come back to you on that separately. |
|
Thank you, Colin, both are in. The pairing paragraph now matches what 0.1.13 does, and the Wi-Fi line points at kernel #187, which is where it landed. I checked that the tool and test changes are the same as the ones I tested last time, ran the test again on today's main with this merged (all pass), and I'm merging it now. Thanks for the offer on older factory builds. Whenever you get to it, just the |
|
@derekross, here's the older-build check you asked for: BP2A.250705.008 (Android 16, July 2025): AP4A.250105.002 (Android 15, January 2025): So the names didn't move between Android 15, 16 and CP3A.261005.005: the same Google's files stayed on my PC; the staged copies were deleted after each run. |
@derekross, the small things from your review of #722, in one commit:
BT_NAMEgives the Bluetooth check a name whereBT_CHIPis a pattern, so husky's refusal now reads "BCM.hcd is not a Pixel 8 Pro (G5SN_V_HK3) Bluetooth patch". The other devices have noBT_NAMEand keep their chip name in the message.cs40l26.wmfwfor husky. A new test gives husky a Halo WMFW that isn't the CS40L26's, and it is refused with "cs40l26.wmfw is not a CS40L26 firmware". I checked that it bites, as you did: with husky taken out of the haptics check, this test fails.Tested
tests/extract-vendor-firmware: all pass, including the two husky refusal cases.tools/pr-check origin/main: all ok.Your question on older factory builds
I've only run the tool on CP3A.261005.005, the build my unit came with. I don't have an older husky image on hand. If it's useful, I can fetch one or two older husky factory images from Google's page, run the tool on each, and post just the
==>lines here.