Repository navigation
phone-provision: --fingerprint restores from a backup directory with a space - #725
Merged
derekross merged 1 commit intoNov 13, 2026
Conversation
…a space With --restore DIR --fingerprint, the backup check listed the fingerprint archive through an unquoted command substitution, so a DIR with a space in it was split there and the run stopped with "no <DIR up to the space>" before anything was staged. The same DIR works without --fingerprint, because the config archive was already quoted. The archives to check are now an array, so each path stays one word. Tested: the dry run (--dry-run --skip-extract --restore DIR --fingerprint) from a backup directory with a space, with a phone stand-in that fails if it is called, stops on main and checks both archives with this change; --work with a space and a factory image path with a space also run clean in a dry run. tests/phone-provision gains that dry run (it fails on main's tool), tools/pr-check origin/main and tests/all pass. Not tested: a run against a phone, and the suite's container run (no Docker here). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thank you, this is a tidy fix. I checked the rest of Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
tools/phone-provision --restore DIR --fingerprintstops withno <DIR up to the space>when DIR has a space; without--fingerprintthe same DIR works. The backup check listed the fingerprint archive through an unquoted$(...), which split its path. The archives are now an array. It is the same kind of fix as #625 and #646 (a path with a space in the extractors and the installer). I found it reading the code.--workand a factory image path with a space already work in a dry run; unchanged. Regression test (a stand-in, not the reproduction):tests/phone-provisioncopies its synthetic backup to a directory with a space and runs the same dry run; on main's tool it fails withnot ok - --fingerprint restores from a backup directory with a space.Device and build
uname -r): not applicableChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none): n/a, no package changedversionbumped, and the new version is in the commit subject: n/aCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: no phone ran this change. It is a laptop-side check that runs before the phone is contacted, and CONTRIBUTING.md §6.5 asks for no report for such a tool change.
The real tool from the checkout, a backup like the suite's (made-up contents), a phone stand-in that fails if called, no factory image. My script strips only colour codes. Before, on main (12258d9):
After, this branch:
Generated with Claude Opus 5.5 in T3 Code Nightly