Repository navigation
install-phone: --help says the next run removes a killed run's directory - #700
Merged
derekross merged 1 commit intoNov 13, 2026
Merged
Conversation
Since derekross#682 a run that finds no other run of the installer live removes the verify.* directories killed runs left in --work, but --help still described --work only as where the image copy goes. The --work entry now says so, and that directories left by installers without this cleanup are kept, as derekross#682 does. Docs only: the header comment is what --help prints, here and as a bundle's install. Tested: tools/install-phone --help on main and on this commit (the --work entry gains four lines, the column is kept); tests/tools-help, tools/pr-check and tests/all pass. Not tested: a phone (none is needed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 9 tasks
Owner
|
Thanks, @only21mil. That is the second small thing from #682. I checked that only the header changes (without its comment lines the file is main's), that the sentence says what the code does (a run that gets the lock alone removes the marked |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The maintainer's second point on #682 suggested that the header's
--workentry say the next run removes killed runs' directories.It now does, naming the
verify.*directories, and says that ones left by installers without this cleanup stay, as #682 does. Docs only; a bundle'sinstall --helpprints the same header.Before on main, after on this branch (the
sedcuts out two entries):No new test for one sentence of help;
tests/tools-helppasses.Device and build
uname -r): noneChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: only the installer's help text changes, and none of it runs on a phone (CONTRIBUTING.md §6.5).
Generated with Claude Opus 5.5 in T3 Code Nightly