Skip to content

install-phone: --help says the next run removes a killed run's directory - #700

Merged
derekross merged 1 commit into
derekross:mainfrom
only21mil:build/install-phone-work-help-sweep
Nov 13, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
only21mil:build/install-phone-work-help-sweep

Conversation

@only21mil

Copy link
Copy Markdown
Contributor

What and why

The maintainer's second point on #682 suggested that the header's --work entry say the next run removes killed runs' directories.

It now does, naming the verify.* directories, and says that ones left by installers without this cleanup stay, as #682 does. Docs only; a bundle's install --help prints the same header.

Before on main, after on this branch (the sed cuts out two entries):

$ git rev-parse --short HEAD
adda276a
$ tools/install-phone --help | sed -n '/^    --work /,/^    --bootloader/p; /^    --verify-only/,/^$/p'
    --work DIR             where the local image copy goes (default
                           ~/.cache/omamobile-install; needs the image's size free)
    --bootloader-slots-match VERSION
    --verify-only          check the files (a bundle's signature, checksums,
                           manifest.json, root image and slot B's ramdisk,
                           read in a directory of its own in --work that
                           it removes) and stop before the phone is
                           contacted

exit 0
$ git rev-parse --short HEAD
2ea7c9b2
$ tools/install-phone --help | sed -n '/^    --work /,/^    --bootloader/p; /^    --verify-only/,/^$/p'
    --work DIR             where the local image copy goes (default
                           ~/.cache/omamobile-install; needs the image's
                           size free). The next run that finds no other
                           run live removes killed runs' verify.*
                           directories; ones left by installers without
                           this cleanup are kept
    --bootloader-slots-match VERSION
    --verify-only          check the files (a bundle's signature, checksums,
                           manifest.json, root image and slot B's ramdisk,
                           read in a directory of its own in --work that
                           it removes) and stop before the phone is
                           contacted

exit 0

No new test for one sentence of help; tests/tools-help passes.

Device and build

  • Phone: none: docs/tools only
  • Kernel release (uname -r): none
  • Packages changed, with versions: none

Checks (no phone needed)

  • tools/pr-check origin/main passes
  • tests/all passes
  • tests/packages passes (or the packages I touched: none)
  • Each changed package has its version bumped, and the new version is in the commit subject
  • Commits have area prefixes and bodies that say why; any AI help is a Co-Authored-By: or Assisted-by: trailer, never a Signed-off-by:

On the phone

  • I ran this on my own phone, booted into this build
  • Runbook steps passed (plan, step, result): none, no plan step
  • What I did not test: a phone
  • Nothing in this change writes outside slot B and userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)
tools/phone-smoke report

Not applicable: only the installer's help text changes, and none of it runs on a phone (CONTRIBUTING.md §6.5).

Generated with Claude Opus 5.5 in T3 Code Nightly

Since derekross#682 a run that finds no other run of the installer live removes
the verify.* directories killed runs left in --work, but --help still
described --work only as where the image copy goes. The --work entry
now says so, and that directories left by installers without this
cleanup are kept, as derekross#682 does. Docs only: the header comment is what
--help prints, here and as a bundle's install.

Tested: tools/install-phone --help on main and on this commit (the
--work entry gains four lines, the column is kept); tests/tools-help,
tools/pr-check and tests/all pass. Not tested: a phone (none is needed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@derekross

Copy link
Copy Markdown
Owner

Thanks, @only21mil. That is the second small thing from #682. I checked that only the header changes (without its comment lines the file is main's), that the sentence says what the code does (a run that gets the lock alone removes the marked verify.* directories, and one without the mark is never removed), and that --help and tests/tools-help are fine with it on today's main. Merging.

@derekross
derekross merged commit 2690626 into derekross:main Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants