Repository navigation
tests/install-phone-initramfs: a passing run prints no "Killed" notice - #699
Merged
derekross merged 1 commit intoNov 13, 2026
Merged
Conversation
Since derekross#682 a passing run prints bash's job notice for the install the suite kills ("line 136: ... Done ... Killed ... exec "$BUNDLE/install" ..."), which in a CI log reads as a failure. The notice comes from the held job's own shell, whose stderr is the suite's, so the 2>/dev/null around the later wait never caught it, and disown wouldn't either (it also stops wait from waiting for the killed run). The held job's stderr now goes to /dev/null; its output is in OUT as before, and the wait is plain. Tested: the suite on main prints the notice and exits 0; on this commit it prints the same ok lines and no notice, exit 0. The tool from before derekross#682 and six sweep mutants (no exclusive check, the shared lock let go after marking, no mark check with and without the run's own directory spared, no mark written, a blocking exclusive lock) still fail it. tools/pr-check and tests/all pass. tests/make-bundle, which also kills a run with SIGKILL, prints no notice. Not tested: a phone (none is needed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 9 tasks
Owner
|
Thanks, @only21mil. That is the first of the two small things from #682, and the explanation is the useful part: the notice comes from the held job's own shell, so the redirect round I ran it merged onto today's main: with main's test file the "Killed" notice is printed and the suite passes; with yours there is no notice and the same eleven |
5 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
This follows the first small thing in the maintainer's note on #682: a passing
tests/install-phone-initramfsprints bash's job notice for the install it kills, which in a CI log reads as a failure.The background job's own shell prints it, so the
2>/dev/nullaround the laterwaitnever caught it. I trieddisown: the notice stays, andwaitstops waiting for the killed run. So that job's stderr now goes to/dev/null; its output still goes to its OUT file, which the suite prints on a failure.I captured the before run on main
1d4df112before changing the test, then repeated it on98cd6d94. Current green mainadda276aleaves the test unchanged and merges cleanly with the candidate. The suite exits 0 on that main and on the local merged tree, with the notice only on main. Each block leaves out the same 11oklines (grep -v '^ok - ').No new test: the runs above are the check. The suite still fails with the tool from before #682 and with each of six broken sweeps (no exclusive check, the shared lock let go after marking, no mark check with and without the run's own directory spared, no mark written, a blocking exclusive lock).
tests/make-bundlealso kills a run with SIGKILL and prints no notice.Device and build
uname -r): noneChecks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)tools/phone-smokereportNot applicable: the change is to a test's output on the laptop, and nothing in it runs on a phone (CONTRIBUTING.md §6.5).
Generated with Claude Opus 5.5 in T3 Code Nightly