Repository navigation
Conversation
…o the input method The input method's keyboard grab sent a keymap only when the keyboard changed. squeekboard replaces its virtual keyboard's keymap on a layout change, so fcitx5 holding the grab kept the old one, and squeekboard's space reached it as "l". Compare the keymap too. On the 7 Pro with fcitx5 and Mozc: space converts now (before, "l"). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
9 tasks done
Contributor
Author
|
Closing for now together with #693, the Japanese input it was for. I'll bring it back with that work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The input method's keyboard grab sent a keymap only when the keyboard changed. squeekboard replaces its virtual keyboard's keymap on a layout change, so an input method holding the grab (fcitx5) kept the old one: squeekboard's space reached fcitx5 as
l. Patch 0003 compares the keymap too. Needed for Japanese input with fcitx5 and Mozc (a follow-up PR).Device and build
uname -r): 7.3.0-rc6-omamobile-g1a9d1d4e9289Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: hyprland, no test of its own; the patch applies with--fuzz=0)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
l(keycode 46) on 3.3; on 3.4 space converts. Session, display and squeekboard otherwise as before.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)🤖 Generated with Claude Code