Repository navigation
docs/review: lessons from rounds 49 to 52 (L-658 to L-775, C-36 to C-43) - #687
Merged
Merged
Conversation
The candidate lessons of four review rounds were never added: 251 of them, in the rounds' review files. Each round's were read against all of the existing lessons, merged where two reviews said the same thing, and cut to the ones that are a check that caught something real or a correction of a mistake of ours: 118 lessons and 8 corrections. round 49: L-658 to L-693 round 50: L-694 to L-724 round 51: L-725 to L-751 round 52: L-752 to L-775 Five near-duplicates between rounds were dropped at the merge (a second correction about #567's rollback index, a second floating-dialog screenshot rule, a second #648 scratch-directory rule, a third merge condition for kernel #224, a second "in review" wording check). Round 52's include what the round's review of the maintainer's own merges found, and three things from the day itself: the Omarchy 4.5 pin moved on an update test from a phone prepared in a way users' phones were not (C-42, with the lesson on what delivers a fix to each phone); a test build of reboot-to run with --help, which restarted the phone; and this file having outgrown one read. One lesson is new here: date's %3N is not a millisecond clock on uutils (L-765). The lesson files are rebalanced: 17 files, the largest 26 kB. tests/review-lessons passes, and all 692 earlier entries are unchanged. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…43) (derekross#687) The candidate lessons of four review rounds were never added: 251 of them, in the rounds' review files. Each round's were read against all of the existing lessons, merged where two reviews said the same thing, and cut to the ones that are a check that caught something real or a correction of a mistake of ours: 118 lessons and 8 corrections. round 49: L-658 to L-693 round 50: L-694 to L-724 round 51: L-725 to L-751 round 52: L-752 to L-775 Five near-duplicates between rounds were dropped at the merge (a second correction about derekross#567's rollback index, a second floating-dialog screenshot rule, a second derekross#648 scratch-directory rule, a third merge condition for kernel derekross#224, a second "in review" wording check). Round 52's include what the round's review of the maintainer's own merges found, and three things from the day itself: the Omarchy 4.5 pin moved on an update test from a phone prepared in a way users' phones were not (C-42, with the lesson on what delivers a fix to each phone); a test build of reboot-to run with --help, which restarted the phone; and this file having outgrown one read. One lesson is new here: date's %3N is not a millisecond clock on uutils (L-765). The lesson files are rebalanced: 17 files, the largest 26 kB. tests/review-lessons passes, and all 692 earlier entries are unchanged. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The candidate lessons from four review rounds had never been added. This adds the ones worth keeping, for the maintainer's confirmation: nothing here is confirmed until it's merged.
How they were chosen. Each round's candidates (251 in all, from the rounds' review files) were read against every existing lesson, merged where two reviews said the same thing, and cut to those that are a check that caught something real or a correction of a mistake of ours.
118 lessons and 8 corrections. By area: safety 25, shared code 16, shell 32, kernel 3, gates 16, reviews 13, claims 13, corrections 8.
Dropped at the merge, as near-duplicates between rounds: a second correction about #567's rollback index, a second floating-dialog screenshot rule, a second #648 scratch-directory rule, a third merge condition for kernel #224, and a second "in review" wording check.
From the day itself, in round 52's set:
reboot-torun with--helprestarted the phone: read a phone tool's argument handling before running it.date +%s%3Nis not a millisecond clock on uutils'date, which is whytest/keys.shfailed about one run in six on the build machine.Open points the curators raised, for you to settle by editing or deleting an entry:
kare included (two entries, both under Reviews and merging).flockon an inherited descriptor (make-bundle: a second run for the same bundle can't remove the first one's build #664, the check came back clean), and version-collision repeats covered by L-404 and L-426.The lesson files are rebalanced: 17 files, the largest 26 kB.
tests/review-lessonspasses, and all 692 earlier entries are unchanged, byte for byte.🤖 Generated with Claude Code