Skip to content

docs/review: lessons from rounds 49 to 52 (L-658 to L-775, C-36 to C-43) - #687

Merged
derekross merged 1 commit into
mainfrom
docs-review-rounds49-52
Nov 12, 2026
Merged

derekross merged 1 commit into
mainfrom
docs-review-rounds49-52

Conversation

@derekross

Copy link
Copy Markdown
Owner

The candidate lessons from four review rounds had never been added. This adds the ones worth keeping, for the maintainer's confirmation: nothing here is confirmed until it's merged.

How they were chosen. Each round's candidates (251 in all, from the rounds' review files) were read against every existing lesson, merged where two reviews said the same thing, and cut to those that are a check that caught something real or a correction of a mistake of ours.

Round Candidates Lessons Corrections
49 84 L-658 to L-693 C-36 to C-40
50 66 L-694 to L-724 C-41
51 57 L-725 to L-751 none kept
52 44 L-752 to L-775 C-42, C-43

118 lessons and 8 corrections. By area: safety 25, shared code 16, shell 32, kernel 3, gates 16, reviews 13, claims 13, corrections 8.

Dropped at the merge, as near-duplicates between rounds: a second correction about #567's rollback index, a second floating-dialog screenshot rule, a second #648 scratch-directory rule, a third merge condition for kernel #224, and a second "in review" wording check.

From the day itself, in round 52's set:

Open points the curators raised, for you to settle by editing or deleting an entry:

The lesson files are rebalanced: 17 files, the largest 26 kB. tests/review-lessons passes, and all 692 earlier entries are unchanged, byte for byte.

🤖 Generated with Claude Code

The candidate lessons of four review rounds were never added: 251 of
them, in the rounds' review files. Each round's were read against all of
the existing lessons, merged where two reviews said the same thing, and
cut to the ones that are a check that caught something real or a
correction of a mistake of ours: 118 lessons and 8 corrections.

  round 49: L-658 to L-693
  round 50: L-694 to L-724
  round 51: L-725 to L-751
  round 52: L-752 to L-775

Five near-duplicates between rounds were dropped at the merge (a second
correction about #567's rollback index, a second floating-dialog
screenshot rule, a second #648 scratch-directory rule, a third merge
condition for kernel #224, a second "in review" wording check).

Round 52's include what the round's review of the maintainer's own merges
found, and three things from the day itself: the Omarchy 4.5 pin moved on
an update test from a phone prepared in a way users' phones were not
(C-42, with the lesson on what delivers a fix to each phone); a test
build of reboot-to run with --help, which restarted the phone; and this
file having outgrown one read. One lesson is new here: date's %3N is not
a millisecond clock on uutils (L-765).

The lesson files are rebalanced: 17 files, the largest 26 kB.
tests/review-lessons passes, and all 692 earlier entries are unchanged.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit e4c92a8 into main Nov 12, 2026
2 checks passed
@derekross
derekross deleted the docs-review-rounds49-52 branch November 12, 2026 13:06
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…43) (derekross#687)

The candidate lessons of four review rounds were never added: 251 of
them, in the rounds' review files. Each round's were read against all of
the existing lessons, merged where two reviews said the same thing, and
cut to the ones that are a check that caught something real or a
correction of a mistake of ours: 118 lessons and 8 corrections.

  round 49: L-658 to L-693
  round 50: L-694 to L-724
  round 51: L-725 to L-751
  round 52: L-752 to L-775

Five near-duplicates between rounds were dropped at the merge (a second
correction about derekross#567's rollback index, a second floating-dialog
screenshot rule, a second derekross#648 scratch-directory rule, a third merge
condition for kernel derekross#224, a second "in review" wording check).

Round 52's include what the round's review of the maintainer's own merges
found, and three things from the day itself: the Omarchy 4.5 pin moved on
an update test from a phone prepared in a way users' phones were not
(C-42, with the lesson on what delivers a fix to each phone); a test
build of reboot-to run with --help, which restarted the phone; and this
file having outgrown one read. One lesson is new here: date's %3N is not
a millisecond clock on uutils (L-765).

The lesson files are rebalanced: 17 files, the largest 26 kB.
tests/review-lessons passes, and all 692 earlier entries are unchanged.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant