Repository navigation
device/tegu MODEM-PLAN: where stock's values for the GNSS handshake pins come from - #679
Merged
Merged
Conversation
…ins come from The readings of the two pins were compared with "stock's" pull and function without saying which file has them. They are the groups gnss_spi_irq (gpa5-4) and gnss_spi_int (gpp2-3) in Google's zuma-cp-s5400-phone-gnss.dtsi, named by gnssif's pinctrl-0; the plan now says so and links the file at the commit it was read at.
Owner
|
Thank you, this is exactly the small thing I asked for on #590. I fetched Google's |
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…ins come from (derekross#679) The two stock values the 2026-11-10 pin readings are compared with now name their source: `gnss_spi_irq` (gpa5-4) and `gnss_spi_int` (gpp2-3) in Google's `zuma-cp-s5400-phone-gnss.dtsi`, linked at the commit FAR-ALIVE-PLAN cites. This was the one point left open when derekross#590 merged. Checked against the file at that commit, and against Google's tegu board files for an override (none).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The small thing left from #590's review: the two stock values the pin readings are compared with now name their source. gpa5-4 is
gnss_spi_irqunder&pinctrl_2(an interrupt, pull-down, drive 0, kept as it was in power-down), gpp2-3 isgnss_spi_intunder&pinctrl_11(an output, no pull, drive 0), both in Google'szuma-cp-s5400-phone-gnss.dtsi, wheregnssif'spinctrl-0names them. The plan links the file at the commit it was read at, the same one FAR-ALIVE-PLAN cites.One sentence in section P of tegu's MODEM-PLAN; nothing else changes.
tools/pr-check origin/mainpasses.