Skip to content

device/dipper: tighten NFS guard follow-up checks - #675

Merged
derekross merged 1 commit into
derekross:mainfrom
quatrixone:followup/dipper-owner-notes
Nov 12, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
quatrixone:followup/dipper-owner-notes

Conversation

@quatrixone

Copy link
Copy Markdown
Contributor

Follow up on owner feedback in #503 and #330.

  • Test that NFS mode reports a writable main UFS disk.
  • Assert boot_nfs checks ufs_unguarded before stopping initramfs processes.
  • Clarify that the earlier whole-disk removal records belong to the 93484a91 and f2f5cb2e boots, not the e2cdb765 image.

Checks: tests/storage-guard; tools/pr-check origin/main; git diff --check.

Record which earlier boots removed the whole-disk node, separately from the e2cdb765 image. Extend the storage-guard regression test to catch a writable NFS disk and to keep the handover guard check before stopping initramfs processes.
@derekross

Copy link
Copy Markdown
Owner

Thank you, @quatrixone. This closes both follow-ups, and exactly as asked.

I ran tests/storage-guard on your head merged onto today's main, then broke the init three ways to see whether the new lines notice: with ufs_unguarded skipping sda in NFS mode as it does otherwise, the suite fails on "NFS mode reports a writable main UFS disk"; with the check taken out of boot_nfs, and again with the check moved below the kill -9 -1, it fails on "boot_nfs checks ufs_unguarded before it stops the initramfs's processes". So both NFS-only lines are covered now.

The NOTES sentence matches the table above it: the 93484a91… and f2f5cb2e… rows record /dev/sda absent, and the e2cdb765… rows record it present. That is the reading I thought was right, and it is good to have it in your words.

One word for your next notes push, not for this one: the paragraph says the final #505 image's check is "recorded below", and with the file newest first that section is above it.

Merging.

@derekross
derekross merged commit 1d4df11 into derekross:main Nov 12, 2026
2 checks passed
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…nd hand-over order are tested, and the notes say which boots removed /dev/sda (derekross#675)

Two assertions for the NFS-only lines derekross#503 left untested: in NFS mode `ufs_unguarded` reports a writable `sda`, and `boot_nfs` calls it before `kill -9 -1`. Dipper's notes now tie the whole-disk-node removal to the `93484a91…` and `f2f5cb2e…` boots the table records, apart from the `e2cdb765…` image where the node was present. `initramfs/init` is unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants