Skip to content

omamobile-firstboot 0.1.5: a first boot without a name or email finishes user setup - #674

Merged
derekross merged 1 commit into
mainfrom
firstboot-blank-identity
Nov 12, 2026
Merged

derekross merged 1 commit into
mainfrom
firstboot-blank-identity

Conversation

@derekross

Copy link
Copy Markdown
Owner

Found by the round 52 review of #662.

0.1.4 wrote git's name and email in the user-setup step with a bare ${C[FULL_NAME]} and ${C[EMAIL]}. tools/install-phone writes those keys only when the owner gave them, so under set -u a blank one ended the step with "unbound variable", before omamobile-setup-user, the credential record and the lock toggles. The step is optional, so firstboot still marked itself done and never retried.

Reach: phones that updated are unaffected, since firstboot ran on them long ago. The next root image would have carried it; no image with 0.1.4 has been built for release.

Fix: both keys are read with a default.

Test: the no-name case checked only the exit status and that git wasn't called. It now also fails on an unset-key message or a run that ends with warnings. Against 0.1.4's script it fails with "a run without a name and email reads no unset key"; with this change test/all passes.

Not run on a phone: it needs a fresh install.

🤖 Generated with Claude Code

…hes user setup

0.1.4 (#662) wrote git's name and email in the user-setup step with a
bare ${C[FULL_NAME]} and ${C[EMAIL]}. The installer writes those keys
only when the owner gave them, so under set -u a blank one ended the step
with "unbound variable", before omamobile-setup-user, the credential
record and the lock toggles. The step is optional, so firstboot still
marked itself done and never retried. Phones that updated are unaffected:
firstboot ran on them long ago. The next root image would have carried it.

Both keys are now read with a default. The test's no-name case checked
only the exit status and that git wasn't called; it now also fails on an
unset-key message or a run that ends with warnings, and fails that way
against 0.1.4's script.

Found by the round 52 review of #662.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit e6bc8e3 into main Nov 12, 2026
2 checks passed
@derekross
derekross deleted the firstboot-blank-identity branch November 12, 2026 00:55
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…hes user setup (derekross#674)

0.1.4 (derekross#662) wrote git's name and email in the user-setup step with a
bare ${C[FULL_NAME]} and ${C[EMAIL]}. The installer writes those keys
only when the owner gave them, so under set -u a blank one ended the step
with "unbound variable", before omamobile-setup-user, the credential
record and the lock toggles. The step is optional, so firstboot still
marked itself done and never retried. Phones that updated are unaffected:
firstboot ran on them long ago. The next root image would have carried it.

Both keys are now read with a default. The test's no-name case checked
only the exit status and that git wasn't called; it now also fails on an
unset-key message or a run that ends with warnings, and fails that way
against 0.1.4's script.

Found by the round 52 review of derekross#662.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant