Repository navigation
omamobile-firstboot 0.1.5: a first boot without a name or email finishes user setup - #674
Merged
Merged
Conversation
…hes user setup 0.1.4 (#662) wrote git's name and email in the user-setup step with a bare ${C[FULL_NAME]} and ${C[EMAIL]}. The installer writes those keys only when the owner gave them, so under set -u a blank one ended the step with "unbound variable", before omamobile-setup-user, the credential record and the lock toggles. The step is optional, so firstboot still marked itself done and never retried. Phones that updated are unaffected: firstboot ran on them long ago. The next root image would have carried it. Both keys are now read with a default. The test's no-name case checked only the exit status and that git wasn't called; it now also fails on an unset-key message or a run that ends with warnings, and fails that way against 0.1.4's script. Found by the round 52 review of #662. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…hes user setup (derekross#674) 0.1.4 (derekross#662) wrote git's name and email in the user-setup step with a bare ${C[FULL_NAME]} and ${C[EMAIL]}. The installer writes those keys only when the owner gave them, so under set -u a blank one ended the step with "unbound variable", before omamobile-setup-user, the credential record and the lock toggles. The step is optional, so firstboot still marked itself done and never retried. Phones that updated are unaffected: firstboot ran on them long ago. The next root image would have carried it. Both keys are now read with a default. The test's no-name case checked only the exit status and that git wasn't called; it now also fails on an unset-key message or a run that ends with warnings, and fails that way against 0.1.4's script. Found by the round 52 review of derekross#662. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the round 52 review of #662.
0.1.4 wrote git's name and email in the user-setup step with a bare
${C[FULL_NAME]}and${C[EMAIL]}.tools/install-phonewrites those keys only when the owner gave them, so underset -ua blank one ended the step with "unbound variable", beforeomamobile-setup-user, the credential record and the lock toggles. The step is optional, so firstboot still marked itself done and never retried.Reach: phones that updated are unaffected, since firstboot ran on them long ago. The next root image would have carried it; no image with 0.1.4 has been built for release.
Fix: both keys are read with a default.
Test: the no-name case checked only the exit status and that git wasn't called. It now also fails on an unset-key message or a run that ends with warnings. Against 0.1.4's script it fails with "a run without a name and email reads no unset key"; with this change
test/allpasses.Not run on a phone: it needs a fresh install.
🤖 Generated with Claude Code