Skip to content

omamobile-shell: the notification store test skips without node, as the other node tests do - #671

Merged
derekross merged 1 commit into
mainfrom
shell-test-node
Nov 11, 2026
Merged

derekross merged 1 commit into
mainfrom
shell-test-node

Conversation

@derekross

Copy link
Copy Markdown
Owner

The development publish on ms01 failed on 2026-11-11 at omamobile-shell 0.2.125:

test/notifications-store.sh: line 33: node: command not found
error: omamobile-shell: test/all failed

test/notifications-store.sh (#482) runs NotificationsModel.js under node without checking for it, and ms01 has no node. Every other node test in test/all skips on such a machine; this one now does too. CI has node and still runs it.

No version bump: nothing in the package changes, and 0.2.125 hasn't been published yet.

Checked on ms01 with the patched test/all: ok - the shade reads and clears both notification layouts # SKIP no node, and the run goes on past it.

Seen in the same runs, not fixed here: test/keys.sh's "with a panel that never goes off the wait lasts about 1 s" failed twice on ms01 (791 ms, 605 ms against a 900 ms floor) and passed in ten other runs. It can stop a publish the same way; a rerun gets past it. It needs its own look.

🤖 Generated with Claude Code

…he other node tests do

test/notifications-store.sh (#482) runs NotificationsModel.js under node
with no check for it, so test/all failed on ms01, which has no node, and
the development publish stopped at omamobile-shell 0.2.125 on 2026-11-11.
Every other node test in test/all skips there; this one now does too. CI
has node and still runs it.

Run on ms01 with the change: the test reports SKIP and the rest of
test/all goes on.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross
derekross merged commit 3225223 into main Nov 11, 2026
2 checks passed
@derekross
derekross deleted the shell-test-node branch November 11, 2026 23:15
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…he other node tests do (derekross#671)

test/notifications-store.sh (derekross#482) runs NotificationsModel.js under node
with no check for it, so test/all failed on ms01, which has no node, and
the development publish stopped at omamobile-shell 0.2.125 on 2026-11-11.
Every other node test in test/all skips there; this one now does too. CI
has node and still runs it.

Run on ms01 with the change: the test reports SKIP and the rest of
test/all goes on.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant