Repository navigation
omamobile-shell: the notification store test skips without node, as the other node tests do - #671
Merged
Merged
Conversation
…he other node tests do test/notifications-store.sh (#482) runs NotificationsModel.js under node with no check for it, so test/all failed on ms01, which has no node, and the development publish stopped at omamobile-shell 0.2.125 on 2026-11-11. Every other node test in test/all skips there; this one now does too. CI has node and still runs it. Run on ms01 with the change: the test reports SKIP and the rest of test/all goes on. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…he other node tests do (derekross#671) test/notifications-store.sh (derekross#482) runs NotificationsModel.js under node with no check for it, so test/all failed on ms01, which has no node, and the development publish stopped at omamobile-shell 0.2.125 on 2026-11-11. Every other node test in test/all skips there; this one now does too. CI has node and still runs it. Run on ms01 with the change: the test reports SKIP and the rest of test/all goes on. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development publish on ms01 failed on 2026-11-11 at
omamobile-shell0.2.125:test/notifications-store.sh(#482) runsNotificationsModel.jsunder node without checking for it, and ms01 has no node. Every other node test intest/allskips on such a machine; this one now does too. CI has node and still runs it.No version bump: nothing in the package changes, and 0.2.125 hasn't been published yet.
Checked on ms01 with the patched
test/all:ok - the shade reads and clears both notification layouts # SKIP no node, and the run goes on past it.Seen in the same runs, not fixed here:
test/keys.sh's "with a panel that never goes off the wait lasts about 1 s" failed twice on ms01 (791 ms, 605 ms against a 900 ms floor) and passed in ten other runs. It can stop a publish the same way; a rerun gets past it. It needs its own look.🤖 Generated with Claude Code