Skip to content

device/husky: the AoC notes say where the phone-smoke text came from - #655

Merged
derekross merged 2 commits into
derekross:mainfrom
Somnius:husky-notes-1111
Nov 18, 2026
Merged

derekross merged 2 commits into
derekross:mainfrom
Somnius:husky-notes-1111

Conversation

@Somnius

@Somnius Somnius commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@derekross, the two small things from your review of #627, in their own PR so #627 could merge as it was:

Only device/husky/AOC-PLAN.md changes, two lines. tools/pr-check passes.

… and drop the merged-versions clause

The phone-smoke run at 898 s of the second boot had its text lost; the report
on derekross#453 is from a later boot of the same kernel and packages, and the notes
now say so. The Z8 row no longer says the merged versions are Derek's: they
merged under the same numbers.
@derekross

Copy link
Copy Markdown
Owner

@Somnius thank you for following up on both points so quickly. The Z8 row is right now.

In the "Second boot" bullet the new clause landed between the run and its results, so the sentence now reads as if "every required check ok, 0 WARN and 0 errors in dmesg, hottest zone 54 C" were the report you pasted on #453, and that one shows 51 °C (it was up about 20 hours). The 54 °C figures are the 898 s run's, from your first comment there. Moving the clause behind the results fixes it:

tools/phone-smoke was run on that boot (at 898 s of uptime): every required check ok, 0 WARN and 0 errors in dmesg, hottest zone 54 C. Its text was not kept; the report pasted on #453 is from a later boot of the same kernel and packages (up about 20 hours, every required check ok, hottest zone 51 C).

If that matches what you remember, I'll push that one line to your branch and merge, so you don't need to do anything.

@Somnius

Somnius commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

@derekross, yes, that matches both of my comments on #453: the run at 898 s of uptime read 54 °C (#453 (comment)), and the report I pasted later (#453 (comment)) is from a later boot of the same kernel and packages, up 72065 s (about 20 hours), hottest zone 51 °C. Please go ahead and push your line.

…ted report is the later boot

The sentence agreed on the pull request: the run at 898 s (every required
check ok, 54 C, text not kept) and the report pasted on derekross#453 (a later boot,
up about 20 hours, 51 C) are two runs, and each keeps its own numbers.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, Lef, and thanks for checking it against both of your #453 comments. I've pushed the sentence to your branch as one commit on top of yours: the 898 s run keeps its own figures (every required check ok, 54 C, text not kept), and the pasted report is named as the later boot (up about 20 hours, 51 C). Merging once CI is through.

@derekross
derekross merged commit 8934987 into derekross:main Nov 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants