Repository navigation
omamobile-omarchy 0.1.40: acknowledge notification deletion snapshots - #585
marselnenaj wants to merge 1 commit into
Conversation
|
Thank you, @marselnenaj, for opening the provider on its own. I checked what #533 needs from it:
Three things before I merge it:
A small question: 0033 leaves 0029 to 0032 free in the 4.5 family. Are those kept for the 4.5 ports of the double-tap and about-logo patches and the 0017 animation fix? |
Wait for both keyed stores before accepting deletion and return one daemon-owned snapshot of logical keys. Notifications arriving later remain outside that acknowledgment. Keep the legacy 4.0.6 adapter unchanged. Document that the package capability declares the interface but consumers still select their runtime path from the store layout. Rebase only this provider contribution onto the merged 0.1.39 family selector. Both actual-package suites pass for Omarchy 4.0.6-1 and 4.5.0-3; the exact-head phone acceptance remains outstanding. Co-Authored-By: Codex <codex@openai.com>
3514a34 to
4538055
Compare
|
Thank you for checking both package families and the bounded reply size. I have transplanted only the provider contribution onto current main after #471, kept version 0.1.40, and added the README explanation: the package capability declares the interface, while consumers still choose the runtime path from the store layout. All six original provider files and all 29 legacy patch blobs are byte-identical. Both complete package suites pass again against the actual Omarchy archives: 4.0.6-1 in 108.99 seconds and 4.5.0-3 in 25.12 seconds. The requested exact-head 4.5 phone run is still outstanding; I am not substituting my mixed local installation for it. The gaps are not reservations or a claim that those ports are ready. I retained the existing snapshot patch filename while splitting the provider. The legacy double-tap and about-logo patches remain in their legacy family; any 4.5 port still needs its own review. |
|
Thank you, @marselnenaj. The branch is now exactly what I asked for: one commit on main after #471, the I checked the patch again on its own: against the signed omarchy 4.5.0-3 package, 0033 applies with no fuzz after 0015, 0017 and 0019, and in the patched One thing is left, the same as last time: nobody has run it on a phone with Omarchy 4.5. The steps from my last comment stand (27 patches applied, two test notifications, On the number: 0.1.40 is free on main today. #599 asks for the same one, so whichever lands second moves up; I'll set it at merge. A small thing I can fix when merging: the new README would be better titled with the package's name, with the snapshot paragraph as a section. |
Add the notification snapshot provider consumed by #533. Deletion waits until both keyed stores are loaded, and
forgetAlldeletes one daemon-owned logical snapshot and returns its versioned key list. Arrivals outside that snapshot remain outside the acknowledgment.This branch now contains only the provider contribution plus its capability documentation, based on current main after the squash merge of #471. Version 0.1.40 follows the maintainer allocation. The six original provider files are byte-identical to the reviewed provider head; all 29 legacy patch blobs and existing attribution remain unchanged.
omamobile-notification-snapshot=1declares the packaged interface.forgetAllexists only where the 4.5 family is applied, so the consumer still selects its path from the store layout.Validation: both complete package suites pass against the actual Omarchy archives: 4.0.6-1 in 108.99 seconds and 4.5.0-3 in 25.12 seconds. Independent source review and the commit-range policy gate pass. This rebased head still needs the requested exact-head 4.5 phone acceptance: two test notifications, snapshot deletion, empty live/history stores after 20 seconds, then a new notification that remains. The related mixed development installation is not that package-head test.
Policy,
tests/alland every package suite pass in GitHub Actions.