Skip to content

omamobile-omarchy 0.1.40: acknowledge notification deletion snapshots - #585

Open
marselnenaj wants to merge 1 commit into
derekross:mainfrom
marselnenaj:codex/notification-snapshot-provider-v2
Open

marselnenaj wants to merge 1 commit into
derekross:mainfrom
marselnenaj:codex/notification-snapshot-provider-v2

Conversation

@marselnenaj

@marselnenaj marselnenaj commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Add the notification snapshot provider consumed by #533. Deletion waits until both keyed stores are loaded, and forgetAll deletes one daemon-owned logical snapshot and returns its versioned key list. Arrivals outside that snapshot remain outside the acknowledgment.

This branch now contains only the provider contribution plus its capability documentation, based on current main after the squash merge of #471. Version 0.1.40 follows the maintainer allocation. The six original provider files are byte-identical to the reviewed provider head; all 29 legacy patch blobs and existing attribution remain unchanged.

omamobile-notification-snapshot=1 declares the packaged interface. forgetAll exists only where the 4.5 family is applied, so the consumer still selects its path from the store layout.

Validation: both complete package suites pass against the actual Omarchy archives: 4.0.6-1 in 108.99 seconds and 4.5.0-3 in 25.12 seconds. Independent source review and the commit-range policy gate pass. This rebased head still needs the requested exact-head 4.5 phone acceptance: two test notifications, snapshot deletion, empty live/history stores after 20 seconds, then a new notification that remains. The related mixed development installation is not that package-head test.

Policy, tests/all and every package suite pass in GitHub Actions.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @marselnenaj, for opening the provider on its own. I checked what #533 needs from it:

Three things before I merge it:

  1. Order. It goes in right after omamobile-omarchy 0.1.39: select 4.0.6 and 4.5 patch families #471. That lands as a squash, so git rebase --onto origin/main 95a536a3 <your branch> will leave just this commit. I'll title it omamobile-omarchy 0.1.40: acknowledge notification deletion snapshots.
  2. A run on a 4.5 phone. The patch only reaches phones on Omarchy 4.5.0, and none has run it. @jkjoplin, if you have ten minutes for one more: build this head with tools/phone-install-package packages/omamobile-omarchy, check omamobile-omarchy-patches status says 27 applied, send two test notifications and let one time out, then call notifications forgetAll over the shell's IPC. I'd expect a reply of {"version":1,"result":"ok","keys":[…]} naming both, live.json and history.json empty a moment later and still empty after 20 seconds, and a notification sent afterwards to show and stay. No reboot needed.
  3. One README line. The package now provides omamobile-notification-snapshot=1 on every phone, but forgetAll only exists where the 4.5 family is applied. omamobile-shell: wait for notification deletion acknowledgments #533 handles that correctly by looking at the store's layout, so nothing is wrong; I'd just like the README to say what the name means and that a consumer still has to pick the path itself.

A small question: 0033 leaves 0029 to 0032 free in the 4.5 family. Are those kept for the 4.5 ports of the double-tap and about-logo patches and the 0017 animation fix?

Wait for both keyed stores before accepting deletion and return one daemon-owned snapshot of logical keys. Notifications arriving later remain outside that acknowledgment. Keep the legacy 4.0.6 adapter unchanged.

Document that the package capability declares the interface but consumers still select their runtime path from the store layout. Rebase only this provider contribution onto the merged 0.1.39 family selector. Both actual-package suites pass for Omarchy 4.0.6-1 and 4.5.0-3; the exact-head phone acceptance remains outstanding.

Co-Authored-By: Codex <codex@openai.com>
@marselnenaj
marselnenaj force-pushed the codex/notification-snapshot-provider-v2 branch from 3514a34 to 4538055 Compare November 10, 2026 09:04
@marselnenaj marselnenaj changed the title omamobile-omarchy: acknowledge notification deletion snapshots omamobile-omarchy 0.1.40: acknowledge notification deletion snapshots Nov 10, 2026
@marselnenaj

Copy link
Copy Markdown
Contributor Author

Thank you for checking both package families and the bounded reply size. I have transplanted only the provider contribution onto current main after #471, kept version 0.1.40, and added the README explanation: the package capability declares the interface, while consumers still choose the runtime path from the store layout. All six original provider files and all 29 legacy patch blobs are byte-identical.

Both complete package suites pass again against the actual Omarchy archives: 4.0.6-1 in 108.99 seconds and 4.5.0-3 in 25.12 seconds. The requested exact-head 4.5 phone run is still outstanding; I am not substituting my mixed local installation for it.

The gaps are not reservations or a claim that those ports are ready. I retained the existing snapshot patch filename while splitting the provider. The legacy double-tap and about-logo patches remain in their legacy family; any 4.5 port still needs its own review.

@derekross

Copy link
Copy Markdown
Owner

Thank you, @marselnenaj. The branch is now exactly what I asked for: one commit on main after #471, the provides line, and the README paragraph that says a consumer still has to choose its path from the store layout. Thanks also for the plain answer on the 0029-0032 gap.

I checked the patch again on its own: against the signed omarchy 4.5.0-3 package, 0033 applies with no fuzz after 0015, 0017 and 0019, and in the patched Service.qml both stores reach "loaded" whether their file reads or fails, so the new busy answer can't outlast startup. The 4.0.6 family is untouched, and CI is green.

One thing is left, the same as last time: nobody has run it on a phone with Omarchy 4.5. The steps from my last comment stand (27 patches applied, two test notifications, forgetAll, both stores empty after 20 seconds, a new notification stays). @jkjoplin, if you have ten minutes for it I'd be grateful; @marselnenaj, a run on your own 4.5 phone with this exact head installed as the package would do just as well, with pacman -Q omamobile-omarchy and the status line in the report.

On the number: 0.1.40 is free on main today. #599 asks for the same one, so whichever lands second moves up; I'll set it at merge. A small thing I can fix when merging: the new README would be better titled with the package's name, with the snapshot paragraph as a section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants