Skip to content

install-phone: preserve development boot-update policy and serial pin - #563

Merged
derekross merged 1 commit into
derekross:mainfrom
latentoperator:revision/install-development-policy-20261109
Nov 12, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
latentoperator:revision/install-development-policy-20261109

Conversation

@latentoperator

@latentoperator latentoperator commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Preserve a development installation's test kernel by accepting descriptor BOOT_UPDATE_AUTO_WRITE=yes|no and writing that AUTO_WRITE value into the prepared root. Omitted settings retain yes. Invalid values refuse before phone queries or image preparation.

The delta now contains only this policy, its documentation and fixtures. Main's --serial implementation is retained; the redundant FASTBOOT_SERIAL mechanism is removed.

Validation on main 6ee77fb: full tests/all, policy and the complete fake-fastboot installer suite pass, including default/development image contents, invalid-policy refusal and main's serial checks. All installer execution used fixtures; no physical installation, flash or partition write occurred. Independent review found no remaining source blocker. Fresh published-head CI is tracked below.

Published-head validation: both Policy and Tests (tests/all, every package) passed on 7fca38e634b6810721b73d15ded01164656d7d62. The complete combined local integration also passes tests/all and tests/packages with PYTHONUNBUFFERED unset, matching CI.

@derekross

Copy link
Copy Markdown
Owner

Thanks, Chris. Small and well tested, and descriptors without the key keep today's behaviour exactly. Before it leaves draft, could you update the header comment near the top (it still says AUTO_WRITE=yes), mention FASTBOOT_SERIAL in the usage text and in RELEASES as an environment variable, and add BOOT_UPDATE_AUTO_WRITE to the descriptor key table in §3?

@latentoperator
latentoperator force-pushed the revision/install-development-policy-20261109 branch from d8a473b to 0141cb8 Compare November 10, 2026 18:23
@latentoperator
latentoperator marked this pull request as ready for review November 10, 2026 18:31
@derekross

Copy link
Copy Markdown
Owner

Thanks, Chris. All three documentation points from last time are in, and the BOOT_UPDATE_AUTO_WRITE half is what I want: a descriptor without the key gets today's file exactly, a bad value is refused before anything is prepared or any phone is asked, and no is a state omamobile-boot-update and the updater already handle, so it can only mean fewer writes.

One thing changed under you today: #641 landed and gave install-phone a --serial SERIAL option, checked at the very spot where this PR checks FASTBOOT_SERIAL. I'd rather have one way to pin the phone, and the variable would also mean something slightly different here than in bin/omamobile (there it picks one phone out of several; here only one phone may be attached anyway). So please rebase onto main and drop the FASTBOOT_SERIAL part: the check, the "Environment:" lines in the header, its test lines and the RELEASES paragraph. --serial does the same job for your runbooks.

I tried exactly that on a scratch merge: main's --serial kept, your three AUTO_WRITE hunks applied, your serial test lines removed. tests/install-phone passes, with your development-image and invalid-policy cases and main's --serial case. The title can then lose "and serial pin". I'll merge it once it's rebased.

derekross pushed a commit that referenced this pull request Nov 11, 2026
…encies (#561)

Records the Pixel 6a's persistent desktop on its development kernel, what can and can't be reproduced from published sources, the one slot-success write with its before and after bytes, and the hold on further marking. Lists the split pull requests (#562, #563, #565) and the kernel pull requests the port still waits on. Documentation only.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
Keep the existing --serial pin unchanged. Accept only yes or no for the descriptor boot-update policy before preparing an image or contacting a phone; omitted policy retains the existing release image. Verify the prepared development image and fail-before-query behavior.

Co-Authored-By: Codex <noreply@openai.com>
@derekross

Copy link
Copy Markdown
Owner

Thanks, Chris. This is exactly what I asked for: FASTBOOT_SERIAL is gone, main's --serial is untouched, and what's left is the BOOT_UPDATE_AUTO_WRITE key, its row in §3 and its tests.

I ran tests/install-phone on this merged onto today's main and it passes in full, with your development-image and invalid-value cases and main's --serial case. A descriptor without the key still gets AUTO_WRITE=yes, and a bad value is refused before any phone is asked.

Merging. I'll drop "and serial pin" from the title when I squash.

@derekross
derekross merged commit a6a3903 into derekross:main Nov 12, 2026
2 checks passed
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…encies (derekross#561)

Records the Pixel 6a's persistent desktop on its development kernel, what can and can't be reproduced from published sources, the one slot-success write with its before and after bytes, and the hold on further marking. Lists the split pull requests (derekross#562, derekross#563, derekross#565) and the kernel pull requests the port still waits on. Documentation only.

Co-Authored-By: OpenAI Codex <noreply@openai.com>
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…ed root's AUTO_WRITE (derekross#563)

A descriptor may set `BOOT_UPDATE_AUTO_WRITE=no` so that an installed development root keeps its test kernel: the installer writes that value as `AUTO_WRITE` in `/etc/omamobile/boot-update.conf`. Without the key the file says `AUTO_WRITE=yes` as before, and any other value is refused before image preparation or any fastboot query. What the installer itself writes doesn't change.

Co-Authored-By: Codex <noreply@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants