Skip to content

omamobile-shell 0.2.102: keep the shade viewport stable while sliding - #516

Merged
derekross merged 2 commits into
derekross:mainfrom
marselnenaj:codex/quicksettings-stable-shade
Nov 9, 2026
Merged

derekross merged 2 commits into
derekross:mainfrom
marselnenaj:codex/quicksettings-stable-shade

Conversation

@marselnenaj

Copy link
Copy Markdown
Contributor

Opening or dragging Quick Settings changes sheet.y on every animation update. The notification shade also derives its available height from that position, so it repeatedly resizes while moving.

Calculate the available height from the sheet's resting position while retaining the animated position for drawing. Expansion and viewport changes still update the available height; final geometry remains unchanged.

Validation:

  • Real Qt 6.12 tests use the production geometry expressions and cover reveal, drag, expansion, content limits, portrait, landscape and short screens.
  • Baseline replay reproduces repeated viewport changes; the candidate produces zero during reveal. Restoring the old expression fails the stability assertions.
  • Independent source review, strict commit-range policy checks and git diff --check pass.
  • The full shell package test/all passes: 298 successful checks, including the new integrated Qt test.

The proposed package version is 0.2.102; the final version can follow the maintainer's allocation.

Calculate notification capacity from the sheet's resting position instead
of its animated position. The shade still follows sheet movement, while
expansion and screen geometry continue to update its available room.

Exercise the production geometry expressions under real Qt bindings.
The baseline changes room and height during reveal; the candidate keeps
both stable and preserves final portrait, landscape and short-screen
geometry. A control restoring the old calculation fails the assertions.

Keep the change independent of host interfaces, safe-area extensions,
backend scheduling and hardware support. The package increment is proposed
from the current public main and can be adjusted by the maintainer at merge.
No phone frame-rate or runtime qualification is claimed.

Co-Authored-By: Codex <codex@openai.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, @marselnenaj. This is a tidy fix. The sheet rests at Style.gapsOut, so restingTop is exactly where shadeTop ends up, and the final layout doesn't change. The drag offset is never positive, so the shade can't hang past the bottom while you pull. I ran your test here: 5 of 5 pass on this head, --baseline against main shows the 14 room and height changes during the slide, and main's file without --baseline is refused, so the test can't pass on the old code by accident.

What's left is a look on a phone. Your phone is on Omarchy 4.5, where main's shade can't read notifications yet (#482), so it can't show this with rows in the shade. I'll do it on my 7 Pro with a few notifications: open Quick Settings in portrait and in landscape, and drag the sheet up partway.

This conflicts with #518 only in test/all, where both add a block in the same place. I'll keep both. I tried the two together, and both tests pass on the merged file. I'll set the shell version at merge too, since several open PRs say 0.2.102.

@marselnenaj

Copy link
Copy Markdown
Contributor Author

Thanks for checking the combined test blocks and taking the device validation. One clarification: my development phone already has a local 4.5 notification reader and can display rows, but it is not running main's unmodified shade. That does not qualify this exact public PR on a clean phone. #482 already covers the public reader; I am separating our additional notification-deletion fixes instead of duplicating it. Your portrait/landscape and partial-drag check remains outstanding.

@derekross

Copy link
Copy Markdown
Owner

Thanks for the clarification, @marselnenaj, and for keeping the deletion work separate from #482. That makes both easier to review.

Nothing has changed on this one since my last look. I checked it against today's main: the only conflict is the version file, and with #518 merged on top (both test/all blocks kept) your shade test still passes 5 of 5, and the baseline replay still fails as it should.

So what's left is mine: I'll look at it on my 7 Pro with a few notifications in the shade, in portrait and landscape and with a partial drag. Then I'll merge it with the next free shell version in the title. Main is at 0.2.107 now.

# Conflicts:
#	packages/omamobile-shell/version
@derekross
derekross merged commit e20b212 into derekross:main Nov 9, 2026
2 checks passed
@derekross

Copy link
Copy Markdown
Owner

Merged as omamobile-shell 0.2.109. On my 7 Pro the shade stayed steady in portrait, landscape and on a partial drag, with notifications in it. Thank you, Marsel.

robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…derekross#516)

Calculate notification capacity from the sheet's resting position instead
of its animated position. The shade still follows sheet movement, while
expansion and screen geometry continue to update its available room.

Exercise the production geometry expressions under real Qt bindings.
The baseline changes room and height during reveal; the candidate keeps
both stable and preserves final portrait, landscape and short-screen
geometry. A control restoring the old calculation fails the assertions.

Keep the change independent of host interfaces, safe-area extensions,
backend scheduling and hardware support. The package increment is proposed
from the current public main and can be adjusted by the maintainer at merge.
No phone frame-rate or runtime qualification is claimed.

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Derek Ross <derekross@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants