Repository navigation
omamobile-shell 0.2.102: keep the shade viewport stable while sliding - #516
Conversation
Calculate notification capacity from the sheet's resting position instead of its animated position. The shade still follows sheet movement, while expansion and screen geometry continue to update its available room. Exercise the production geometry expressions under real Qt bindings. The baseline changes room and height during reveal; the candidate keeps both stable and preserves final portrait, landscape and short-screen geometry. A control restoring the old calculation fails the assertions. Keep the change independent of host interfaces, safe-area extensions, backend scheduling and hardware support. The package increment is proposed from the current public main and can be adjusted by the maintainer at merge. No phone frame-rate or runtime qualification is claimed. Co-Authored-By: Codex <codex@openai.com>
|
Thank you, @marselnenaj. This is a tidy fix. The sheet rests at What's left is a look on a phone. Your phone is on Omarchy 4.5, where main's shade can't read notifications yet (#482), so it can't show this with rows in the shade. I'll do it on my 7 Pro with a few notifications: open Quick Settings in portrait and in landscape, and drag the sheet up partway. This conflicts with #518 only in |
|
Thanks for checking the combined test blocks and taking the device validation. One clarification: my development phone already has a local 4.5 notification reader and can display rows, but it is not running main's unmodified shade. That does not qualify this exact public PR on a clean phone. #482 already covers the public reader; I am separating our additional notification-deletion fixes instead of duplicating it. Your portrait/landscape and partial-drag check remains outstanding. |
|
Thanks for the clarification, @marselnenaj, and for keeping the deletion work separate from #482. That makes both easier to review. Nothing has changed on this one since my last look. I checked it against today's main: the only conflict is the version file, and with #518 merged on top (both So what's left is mine: I'll look at it on my 7 Pro with a few notifications in the shade, in portrait and landscape and with a partial drag. Then I'll merge it with the next free shell version in the title. Main is at 0.2.107 now. |
# Conflicts: # packages/omamobile-shell/version
|
Merged as omamobile-shell 0.2.109. On my 7 Pro the shade stayed steady in portrait, landscape and on a partial drag, with notifications in it. Thank you, Marsel. |
…derekross#516) Calculate notification capacity from the sheet's resting position instead of its animated position. The shade still follows sheet movement, while expansion and screen geometry continue to update its available room. Exercise the production geometry expressions under real Qt bindings. The baseline changes room and height during reveal; the candidate keeps both stable and preserves final portrait, landscape and short-screen geometry. A control restoring the old calculation fails the assertions. Keep the change independent of host interfaces, safe-area extensions, backend scheduling and hardware support. The package increment is proposed from the current public main and can be adjusted by the maintainer at merge. No phone frame-rate or runtime qualification is claimed. Co-authored-by: Codex <codex@openai.com> Co-authored-by: Derek Ross <derekross@gmail.com>
Opening or dragging Quick Settings changes
sheet.yon every animation update. The notification shade also derives its available height from that position, so it repeatedly resizes while moving.Calculate the available height from the sheet's resting position while retaining the animated position for drawing. Expansion and viewport changes still update the available height; final geometry remains unchanged.
Validation:
git diff --checkpass.test/allpasses: 298 successful checks, including the new integrated Qt test.The proposed package version is 0.2.102; the final version can follow the maintainer's allocation.