Skip to content

panther FINGERPRINT-PLAN: local HBM is on the phone - #495

Merged
derekross merged 1 commit into
derekross:mainfrom
angelrenefm:panther-fingerprint-plan-leftovers
Nov 8, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
angelrenefm:panther-fingerprint-plan-leftovers

Conversation

@angelrenefm

Copy link
Copy Markdown
Contributor

The two leftovers from #458's review (your comment of 2026-11-07 16:13 UTC): the Panel row in section 2 and the end of section 4 still said local HBM wasn't on the phone.

It has been since 2026-11-06. What's on the phone, read today:

  • kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795, with "LHBM gamma 0b9c49f154" at each boot;
  • allow_lhbm Y, local_hbm_max_timeout 3000;
  • the HAL places the sensor at (540, 1713), radius 100, the driver's centre;
  • the bridge's "LHBM on refused" only with the screen dark, as the driver means it to.

Not checked: the timeout itself (a finger held past 3 s). The plan says so.

Documentation only; tools/pr-check passes.

I used AI help (Claude) to work on this.

The two leftovers from derekross#458's review: the Panel row and the end of
section 4 still said local HBM wasn't on the phone. It has been since
2026-11-06 (kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795): allow_lhbm
Y, local_hbm_max_timeout 3000, the HAL places the sensor at (540, 1713)
radius 100, the driver's centre, and the bridge's "LHBM on refused" came
only with the screen dark. The timeout itself is not checked.

I used AI help (Claude) to work on this.
@derekross

Copy link
Copy Markdown
Owner

Thank you, @angelrenefm, for coming back to both leftovers so quickly. The Panel row and section 4 now say what's on the phone, and you kept the untested timeout visible. That's what I hoped for, and I'm happy to merge this as it is.

A few small things, none blocking:

  • The Sensor position row in section 2 still says "Check in P5 that the circle lands on the sensor". Since P5 passed and section 4 now gives the HAL's (540, 1713) as the driver's centre, it could say that instead.
  • The release in section 4 is the same as the 11-04 run's, …-g44048a9aa795, but section 4 says LHBM arrived on 11-06. How did the LHBM commit get onto the phone: a rebuilt kernel, or the panel module installed by hand under the same release? If it's the module, the next push will replace it. Either way, could you push panther-lhbm to your fork, even unproposed, and give the blob id of panel-samsung-s6e3fc3.c you ran (git rev-parse <commit>:drivers/gpu/drm/panel/panel-samsung-s6e3fc3.c)? Then the plan's result points at code anyone can read.
  • What is the value in "LHBM gamma 0b9c49f154"? If it's a checksum of this panel's own gamma, it's specific to your phone, and I'd quote the line without the value.

I'll merge with the subject device/panther: FINGERPRINT-PLAN, local HBM is on the phone, to match the other plan commits. Thanks again!

@derekross
derekross merged commit 848431e into derekross:main Nov 8, 2026
2 checks passed
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…s#495)

The two leftovers from derekross#458's review: the Panel row and the end of
section 4 still said local HBM wasn't on the phone. It has been since
2026-11-06 (kernel 7.3.0-rc6-omamobile-push1-g44048a9aa795): allow_lhbm
Y, local_hbm_max_timeout 3000, the HAL places the sensor at (540, 1713)
radius 100, the driver's centre, and the bridge's "LHBM on refused" came
only with the screen dark. The timeout itself is not checked.

I used AI help (Claude) to work on this.
@angelrenefm

Copy link
Copy Markdown
Contributor Author

The three leftovers:

  • How local HBM got onto the phone: the panel module, rebuilt with the commit and installed by hand under the same
    release on 2026-11-04 (so you're right, the next kernel push replaces it). Its source is panel-samsung-s6e3fc3.c
    blob 2782206d8f6b, on the panther-lhbm branch of my fork (pushed now, not proposed).
  • The "LHBM gamma" value is this panel's own bytes, so the plan now quotes the line without it.
  • The Sensor position row says what P5 found.

All three are in #813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants