Repository navigation
hyprland 0.57.0-3.2, device-panther 0.1.12: hold the last frame across a rotation on the Pixel 7 (from #446) - #487
Merged
Merged
Conversation
A monitor transform change lays the layer surfaces out again at once, but each client draws at its new size only when it gets to it. Until then Hyprland drew their old buffers stretched over the turned output: stripes, half-empty pages, the home screen's icons in a column, for 200 ms to a second on a Pixel 7 running the phone shell. 0002-render-hold-the-last-frame-across-a-rotation.patch (Renderer.cpp and OpenGL.cpp): - After a transform change, nothing is rendered until every mapped layer surface on the monitor has drawn at its new size, or 500 ms have passed, so the panel keeps its last frame. "Drawn" means the surface's size and its buffer match the new geometry, and a layer that had to redraw has sent a second buffer at that size, or its first has stood for 50 ms. Each check comes from what showed on the phone: Qt resizes the viewport before it commits the new buffer, and its first frame at a new size can still be laid out for the old one. Layers and the active workspaces get their frame callbacks once per refresh while holding, or Qt clients never draw. - Then the new frame turns in from where the old one sat on the glass over 283 ms on a (0.2, 0, 0, 1) curve, while the old frame (copied from the output's buffer before the hold) turns with it and fades out over 116 ms: AOSP's screen rotation values. The new frame is opaque from the start; Android's fade in over black read as a dip to black. Tested on a Pixel 7 (panther, 90 Hz) only, with Hyprland cross-built from this patch against the phone's own libraries and swapped in for /usr/bin/Hyprland, not built with makepkg. Turns between transform 0 and 1, on the home screen: holds of 106 to 228 ms, all ended by the layers, none by the deadline; watched on the phone, no stretched frames or black bar, and a smooth turn. Not checked: transform 3 and 2 (the other landscape side and a half turn), app windows (only layer surfaces are waited for), a 120 Hz panel, and a monitor without layer shell clients. screencopy can't show the turn: it copies the frame before end()'s final copy. I used AI help (Claude) to work on this.
The hold and the turn now run only with OMAMOBILE_ROTATION_HOLD=1 in Hyprland's environment, read once at startup; without it nothing is copied, held or animated, and Hyprland rotates as before. The Pixel 7 Pro keeps that until the hold has run on it. omamobile-device-panther turns it on with /usr/lib/environment.d/40-omamobile-rotation.conf (environment.d values reach Hyprland under uwsm, as the shell package's do). pkgrel 3.2, since 3.1 is published, and the pkgdesc names the rotation hold too. I used AI help (Claude) to work on this.
device-panther 0.1.11 is #485's (fingerprint), so this takes 0.1.12. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…s a rotation on the Pixel 7 (derekross#446) (derekross#487) A rotation on the Pixel 7 used to show stretched frames while the shell redrew. Hyprland now holds the last frame across the turn and hands it over AOSP-style once the layer surfaces have redrawn, with a 500 ms deadline. It runs only when OMAMOBILE_ROTATION_HOLD=1, which device-panther sets in an environment.d drop-in; with the switch off (every other phone, the Pixel 7 Pro included) the hold returns at once and Hyprland draws as before. The patch applies to the 0.57.0 tarball at --fuzz=0, and it was cross-built and booted on the contributor's Pixel 7. Co-Authored-By: Ángel René <17342133+angelrenefm@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
angelrenefm's #446, merged onto main with device-panther set to 0.1.12 (0.1.11 is #485's). The hold runs only when
OMAMOBILE_ROTATION_HOLD=1, which device-panther sets. On the 7 Pro the switch is off, and the review read every hunk: the hold returns at once and Hyprland draws as before. The panther package test passes. Hyprland isn't built in CI (no test/all); the patch applies at --fuzz=0 to the 0.57.0 tarball, and the contributor cross-built and booted it on his Pixel 7.🤖 Generated with Claude Code