Repository navigation
tools: repo-publish --from-main publishes a tree with no prebuilt files (from #289) - #476
Merged
Merged
Conversation
--from-main copies the gitignored prebuilt binaries into out/publish-tree with git ls-files | grep -z /prebuilt/ | rsync. In a checkout that has none (a fresh clone, or one where nothing has been built), grep finds no match and exits 1; under set -euo pipefail that ends the script with no message before it hands over to the clean tree, so nothing is built or published. git now selects the files itself with the pathspec ':(glob)packages/**/prebuilt/**', which picks the same names the grep did and exits 0 when there are none; rsync then gets an empty list and copies nothing. A failing git ls-files or rsync still stops the script before the publisher runs. tests/repo-publish runs the block in a fixture repository: the real git lists the inventory and the real rsync copies it, a stand-in git answers fetch, checkout and clean, and a stand-in publisher in the fixture's out/publish-tree records its arguments. It covers no ignored files, ignored files with none under prebuilt/, prebuilt names with a space and a newline at two depths, a git ls-files that fails at once (a corrupt index) or after some names, and a failing rsync. CI's Arch container gets rsync so the test runs there. Tested on the laptop (no phone; the script never runs on one): tests/repo-publish passes on this commit and fails at its first case on the parent; mutants that swallow the git or rsync status each fail it; the pathspec and the old grep select the same files from a tree of awkward names. tools/pr-check and tests/all pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Resolves three conflicts. checks.yml keeps main's package line, which already has rsync. In repo-publish, #289's pathspec replaces the grep -z that fails under pipefail on an empty list, extended to the boot-files/ directories main copies since. In tests/all, tests/repo-publish is appended to main's list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The check greps tools/repo-publish's source for the old grep -zE filter, which #289's pathspec replaces. On a checkout with cheetah's boot files staged, the old filter and the new pathspec list the same files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 8 tasks
6 of 9 tasks
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…es (derekross#289) (derekross#476) repo-publish --from-main copies the gitignored prebuilt binaries and boot files into its clean origin/main checkout. It listed them with git ls-files piped through grep -z, and grep exits 1 on an empty list, so under pipefail a checkout with none stopped the publish. A git pathspec now picks them (packages/**/prebuilt/** and packages/**/boot-files/**), and an empty list copies nothing. tests/repo-publish covers the empty inventory, NUL-separated names, and an inventory or copy that fails partway, each stopping before anything is published. On a checkout with cheetah's boot files staged, the old filter and the new pathspec list the same files. Co-Authored-By: Victor Vogel <satsdev@only21mil.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only21mil's #289, approved on 11-02, merged onto main with three conflicts resolved:
grep -zthat fails under pipefail on an empty list. It's extended to theboot-files/directories main copies since.tests/repo-publishappended to main's list.tests/repo-publishpasses (4 ok).🤖 Generated with Claude Code