Repository navigation
omamobile-shell: handle failed notification dismissal - #468
marselnenaj wants to merge 1 commit into
Conversation
|
Thank you, @marselnenaj. This is a good catch. Main throws away both the exit status and the reply, and keeping the row's identity through the request is the right fix. Your test runs the real functions out of One thing about the wording: Omarchy's A few things before I can merge:
A suggestion: right now the message stays until the next successful dismissal, so it can sit in the header for the rest of the session. Clearing it when the shade closes, or after a few seconds, would feel more natural. I'll approve the CI run, and I'll set the shell version myself at merge, since several PRs are open at 0.2.101. |
Keep the row identity until the service accepts each forget request. A missing IPC method after an update restores the row immediately and reports the failure; acceptance still uses the existing grace while the file delete is pending. Continue queued rows after a failure and clear presentation errors when the shade closes. Eight actual-function/callback cases cover acceptance, failures, queue order and close behavior. The offscreen error header fits its bounds. Co-Authored-By: Codex <codex@openai.com>
449b525 to
856dece
Compare
|
Thank you, @marselnenaj. The rework reads well. "Accepted" is the right word now, the row keeps its key through the request, a failure no longer stops the queue, and clearing the message when the shade closes is a nice touch. The offscreen shot shows the header fitting, too. What's left is the phone run. Your report is honest about it: it's your 4.5 install with private changes, and main's shade can't even see 4.5's notifications, so that phone can't exercise this path. Phones ship Omarchy 4.0.6, so the run that counts is a 7 Pro on 4.0.6 with this head installed as a package and a few notifications swiped away in a row. I'm travelling this week, so I'll do it when I'm back, unless you have a 4.0.6 phone to hand before then. One thing to settle while you're in both PRs: on 4.0.6, I'll approve the CI run, and I'll set the shell version at merge. |
When a per-row dismissal IPC fails, immediately restore that notification and
show an error instead of leaving it hidden until the 15-second grace expires.
Keep each queued row identity through completion and continue processing later
rows after a failure. Clear the error when the shade closes.
okmeans that the service accepted the request, not that its asynchronousfile write has completed. Accepted requests remain hidden during the existing
grace period. One concrete failure is an Omarchy update where mobile patch0019
was not applied: the missing
forgetmethod exits nonzero and the row nowreturns immediately with an explanation.
Validation: eight actual-function/callback cases, including queue order,
failed/missing acceptance and closing the shade while a request is pending.
The offscreen render uses the actual QuickSettings component with the error
set, inert backends and an isolated home; it is not a phone screenshot.
Device evidence: Pixel9ProXL (komodo), kernel
7.3.0-rc6-omamobile-komodo-gnss-km4. A read-only smoke test on the existing4.5 installation passes all required checks; Bluetooth retains a prior failed
unit/no-controller state. The phone has related private fixes, so this is not
an exact revised-head package test. Real multi-notification swipe acceptance
and an isolated package-head smoke report remain outstanding.
Package version remains a proposal for the maintainer to set at merge.
Current mixed-installation smoke report.
Protocol compatibility: the 4.5 service in #471 accepts a well-formed already-absent key as an idempotent
ok. An already-gone row therefore does not trigger a false dismissal error; malformed keys remain rejected.The remaining physical acceptance is a Pixel 7 Pro on Omarchy 4.0.6 with this head installed as a package and several notifications swiped away consecutively. The current mixed 4.5 smoke report cannot exercise that legacy reader path. The maintainer has offered to perform the 4.0.6 phone run.