Repository navigation
omamobile-gnss: keep the hang marker through shutdown - #462
Conversation
Clear the 9a marker only after systemd has stopped the GNSS service cleanly. A failed stop or unexpected exit retains it so a later location request cannot repeat a hang.
|
Thank you, @W4HO-ham. Moving the clear to One thing before I merge: the template's evidence. Could you add the kernel release ( A small suggestion, not blocking: on the 9a, At merge I'll use your commit's subject with the version, "omamobile-gnss 0.2.8: keep the hang marker through shutdown". |
… what starts GNSS Run by hand, omamobile-gnss-start --retry cleared the hang marker and then refused with "no systemd invocation ID", and the skip message read as if --retry started GNSS. On the 9a it now says that the marker is cleared and that the next location request starts GNSS, in its unit; the skip message says the same. The 7 Pro's messages are unchanged. The test covers the by-hand retry: marker gone, nothing started.
|
Your suggestion is in (e44af0a): on the 9a, The evidence you asked for ( |
|
Thank you, @W4HO-ham. The new by-hand Re-running the pair of sessions on this head rather than reconstructing the One small optional thing: the skip and |
|
The pair of sessions on this head, 2026-11-09 on the palmtop:
The skip and |
omamobile-gnss-start lives in /usr/lib/omamobile-vendor, not on PATH, so the two 9a messages that name its --retry now give the path.
|
Thank you, @W4HO-ham. That's everything I asked for: the kernel release, the Merging as "omamobile-gnss 0.2.8: keep the hang marker through shutdown". |
…s#462) * omamobile-gnss 0.2.8: keep the hang marker through shutdown Clear the 9a marker only after systemd has stopped the GNSS service cleanly. A failed stop or unexpected exit retains it so a later location request cannot repeat a hang. * omamobile-gnss: on the 9a, --retry by hand clears the marker and says what starts GNSS Run by hand, omamobile-gnss-start --retry cleared the hang marker and then refused with "no systemd invocation ID", and the skip message read as if --retry started GNSS. On the 9a it now says that the marker is cleared and that the next location request starts GNSS, in its unit; the skip message says the same. The 7 Pro's messages are unchanged. The test covers the by-hand retry: marker gone, nothing started. * omamobile-gnss: the skip messages give the retry's full path omamobile-gnss-start lives in /usr/lib/omamobile-vendor, not on PATH, so the two 9a messages that name its --retry now give the path.
A hang while the Pixel 9a GNSS service is stopping can clear its persistent hang marker before the GNSS processes have actually exited. A later location request can then start the same failing path again.
Keep the marker until systemd has stopped the service successfully. Associate the session and stop request with the systemd invocation so a failed start, unexpected exit, timed-out stop or later skipped start cannot clear an earlier marker.
Tested:
test/__init__.pyadded.