Repository navigation
bin/omamobile: skip built-in INITRAMFS_MODULES instead of failing - #393
Merged
Merged
Conversation
Since derekross#227 the shared kernel builds sec_acpm, acpm-protocol and the Exynos mailbox in, so raven's INITRAMFS_MODULES stopped "omamobile initramfs" with "no exynos-mailbox.ko" (derekross#391). A module listed in the build's modules.builtin has nothing to load: it is reported and left out. A module that is neither a .ko nor built in still stops the build. The copy loop moves into pack_initramfs_modules so tests/initramfs-steps can run it on a fake modules tree, as it already does with the init's steps. Fixes derekross#391 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks, exactly the shape: the function runs only under DEV_INITRAMFS_MODULES, cheetah's initramfs-config is byte-identical, and the new test case passes here. Merging; fixes #391. |
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…rekross#393) Since derekross#227 the shared kernel builds sec_acpm, acpm-protocol and the Exynos mailbox in, so raven's INITRAMFS_MODULES stopped "omamobile initramfs" with "no exynos-mailbox.ko" (derekross#391). A module listed in the build's modules.builtin has nothing to load: it is reported and left out. A module that is neither a .ko nor built in still stops the build. The copy loop moves into pack_initramfs_modules so tests/initramfs-steps can run it on a fake modules tree, as it already does with the init's steps. Fixes derekross#391 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Fixes #391. Since #227 the shared kernel builds
sec_acpm,acpm-protocoland the Exynos mailbox in, andomamobile initramfsstopped on raven'sINITRAMFS_MODULESbecause it only looked for a.ko. A module listed in the build'smodules.builtinis now reported and left out; one that is neither a.konor built in still stops the build. The copy loop moves into a small function sotests/initramfs-stepscan run it on a fake modules tree, as it already does with the init's steps.Device and build
uname -r): 7.3.0-rc6-omamobile-push1-gb0a658e17f21 (those test images)Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpassestests/packagespasses (or the packages I touched: none)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
INITRAMFS_MODULES).userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)🤖 Generated with Claude Code