Repository navigation
omamobile-omarchy 0.1.32, bin/omamobile: pinned module trees, and no silent replacement in modules-push - #369
Conversation
bbcf8de to
8fcebbc
Compare
|
Thanks, @W4HO-ham. Losing the palmtop's hand-installed display and camera modules to a push was a nasty one, and both halves of this are the right idea. Pins that don't use up rollback slots are neat, and a marker read that fails now stops the push instead of quietly reinstalling. The tests are thorough: Three things before it can merge:
Optional: the AGENTS.md line about |
8fcebbc to
78a5071
Compare
|
Thanks, all three done in a new commit, rebased on main:
From the optional list: the marker read takes stdout only, with a test where an SSH warning on stderr doesn't trigger a reinstall, and the AGENTS.md line describes the guard. The |
|
Thanks, this is the shape I hoped for: the manifest records what each push installed, a rebuilt tree under the same name goes in, and only a hand-added or hand-swapped module refuses; the tests cover each of those, no cmp anywhere, and the stdout-only marker read is a nice touch. One last thing: the new paragraph in docs/RELEASES.md §5.4 still describes the first version ("absent from the archive or has different contents"); could you reword it to the manifest rule, as the AGENTS line already does? Then I'll merge. Note for everyone: the first push after this onto a tree from before the manifest, under an unchanged release name with rebuilt modules, refuses once; that's the old comparison doing its job, and OMAMOBILE_MODULES_REPLACE=1 (or a new release name) gets past it. The dry-run paste from the palmtop can follow when it's back. |
Keep explicitly pinned releases outside the module cleanup rollback count. Stage module archives and refuse replacement when installed drivers would be lost or changed, unless OMAMOBILE_MODULES_REPLACE=1 explicitly permits it. Stop push on marker read errors instead of treating them as an install request. Add offline CLI coverage for replacement refusal, overrides, malformed archives and marker reads, plus cleanup pin tests and usage documentation.
…fest of what each push installed The guard compared the installed tree with the incoming archive, so a fresh build pushed under the same release name (a -dirty tree, or a config change that keeps the name) looked like a hand edit, and the override would have become routine. Each install now writes sha256 sums of every module to .omamobile-modules.sha256. The next push refuses only modules missing from it (added by hand) or not matching it (swapped by hand). A tree from before the manifest is compared with the archive by checksum, so cmp, which the release root lacks, isn't needed. The push reads the module marker from stdout only, so an SSH warning on stderr isn't taken for a mismatch. RELEASES names 0.1.32, and AGENTS.md describes the guard.
Section 5.4 still described the first version of the guard; it now gives the manifest rule and the one-time refusal on a tree from before it, as the AGENTS line does.
|
Done: RELEASES §5.4 now gives the manifest rule and the one-time refusal on a tree from before it. Rebased on main. The dry-run paste follows when the palmtop is back. |
78a5071 to
f374299
Compare
|
Thanks, @W4HO-ham, that wording is exactly the rule now, and the note about the one-time refusal One optional idea for later: |
|
Short field report on the 8 Pro, in case it's useful. On 0.1.31 (installed before this landed) the cleanup timer removed my revert kernel's module tree while a test kernel was running. It keeps the running release, I see 0.1.32 adds |
…silent replacement in modules-push (derekross#369)
On 2026-11-02 the palmtop (Pixel 9a) stopped at the boot logo after a day of test kernels: the push back to its daily kernel replaced the daily's module tree with the kit's archive, and the hand-installed display and camera modules under
extra/andupdates/were gone. The cause (device/tegu NOTES, #368):omamobile-modules-cleanupkeeps the running tree, the next boot's and the two newest others, so during a test boot it removed the older daily tree, and the push back found no marker and sent the archive over it.Two changes:
modules-cleanupkeeps pinned releases: any release listed one per line in/usr/lib/modules/.omamobile-pinnedis kept ("keep : pinned"). A missing file is empty, lines that aren't release-shaped are ignored, and a symlinked file is skipped.test/modules-cleanup.shcovers a pinned older tree kept under three newer ones and a garbage line.modules-pushno longer replaces a tree silently: before replacing an existing tree it stages the archive and compares; if the installed tree has module files the archive lacks, or files that differ (underkernel/too), it refuses, lists the paths and leaves the tree alone, unlessOMAMOBILE_MODULES_REPLACE=1. A failed marker read now stops the push before any write, with the release, the expected checksum and what the read returned, instead of falling through to a replacement.The module-push tests (11) and the cleanup tests (12),
tests/boot-methodandtools/pr-checkpass.packages/omamobile-omarchy/test/allandtests/packagesfail only on QML formatter errors inBackground.qmland the notificationsService.qml, which fail the same way on an untouchedmain. On the palmtop the cleanup keeps 50 trees through a local drop-in until this ships.