Repository navigation
omamobile-audio: give the watchdog's c9 settle tests a 10 s window - #321
Merged
Merged
Conversation
#315 moved the c9 rise test's steps apart, but CI still failed it (#319's run): the watchdog logged its start and nothing else, because on the slower runner the steps arrived after its 80 polls (4 s) were over. The c9 settle tests now poll 200 times (10 s at 0.05 s). A test that expects a mute still ends at the mute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
… the watchdog runs Still failing on CI with the 10 s window: the test set its starting temperature only after it saw the watchdog's "watching" line, and the watchdog's output to a file is buffered, so on CI the line came late and the baseline was taken from the earlier 25 C. The watchdog then muted on "25 -> 33" and the test's check for "33 -> 41" failed. The rise test now sets the measured 33 C before the watchdog starts, so the baseline can't depend on when its output shows; the step from the reference to the measured value in the settle window stays covered by the c9-step test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…erekross#321) * omamobile-audio: give the watchdog's c9 settle tests a 10 s window derekross#315 moved the c9 rise test's steps apart, but CI still failed it (derekross#319's run): the watchdog logged its start and nothing else, because on the slower runner the steps arrived after its 80 polls (4 s) were over. The c9 settle tests now poll 200 times (10 s at 0.05 s). A test that expects a mute still ends at the mute. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d * omamobile-audio: the c9 rise test starts at the measured coil, before the watchdog runs Still failing on CI with the 10 s window: the test set its starting temperature only after it saw the watchdog's "watching" line, and the watchdog's output to a file is buffered, so on CI the line came late and the baseline was taken from the earlier 25 C. The watchdog then muted on "25 -> 33" and the test's check for "33 -> 41" failed. The rise test now sets the measured 33 C before the watchdog starts, so the baseline can't depend on when its output shows; the step from the reference to the measured value in the settle window stays covered by the c9-step test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#315 wasn't enough: #319's CI run failed the same watchdog test. The log shows the watchdog starting and nothing else, because on the slower runner the test's steps arrived after its 80 polls (4 s) had ended. The c9 settle tests now poll 200 times (10 s); a test that expects a mute still ends at the mute. The package's
test/allpasses locally.🤖 Generated with Claude Code
https://claude.ai/code/session_01BeEcdVeSfyLCbijF8XQF1d