Repository navigation
omamobile-shell test/owl-idle: the paused-tick check no longer depends on the wall clock - #207
Merged
Merged
Conversation
…s on the wall clock tickDelay() returns the time to the next boundary, so with the home screen paused the next tick can legitimately be less than a tick away: in the last second of every hiddenTickMs period, which is 10 percent of the clock at 10000 and 1000 ms. The check then asserts something untrue and the run fails, as it did in CI with 554 ms (a clock 9451 ms into its period). Step over that boundary before pausing.
This was referenced Oct 31, 2026
derekross
pushed a commit
that referenced
this pull request
Oct 31, 2026
…-loader boot images (#111) The OnePlus 13 (dodge, SM8750) gets its device descriptor, notes and device package, and bin/omamobile images learns the qcom-abl boot method: a stage-1 chain loader built without UFS (the pack refuses if UFS comes back) that hands over to the device's own chainload/ directory. images refuses without that directory, and push and flash refuse qcom-abl before touching the phone, so nothing in the tree writes this phone yet; the guarded installer follows in a later pull request. The storage guard allows only boot_b and userdata. The Pixel images build byte for byte the same (tests/images-layout). tools/phone-smoke now counts warnings in the 7.x kernels' format, which changes the WARN count on every phone's report (it was always 0 before). The CI Tests failure on this head is the owl-idle timing flake fixed by #207 (the run tested against a base from before it).
This was referenced Oct 31, 2026
derekross
added a commit
that referenced
this pull request
Nov 7, 2026
The matrix re-read against what merged and ran on hardware since 2026-11-02: - Pixel 7: Bluetooth and the torch move to testing (kernel #196, #197, #426); fingerprint moves to WIP (kernel #207; the package side, #458, is in review); AVB footers and reboot=warm noted. - Pixel 8a: a new row, from first light and UFS behind the guard (kernel #192, #206; #414). - Pixel 6 Pro: GPU scaling and cooling (kernel #189) and UFS suspend (kernel #188) merged. - Pixel 9a: GPU levels merged through kernel #96; GNSS's moving-car session (#114) and the link driver (kernel #185). - Pixel 7a: Bluetooth's device tree merged (kernel #98). The Pixel 8 Pro's row is left to #472. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…den-period boundary (derekross#207) In the last second of a hidden period tickDelay() is legitimately shorter than a tick, so the paused-tick assertion failed one second in every ten. The test now waits past that boundary before pausing.
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…-loader boot images (derekross#111) The OnePlus 13 (dodge, SM8750) gets its device descriptor, notes and device package, and bin/omamobile images learns the qcom-abl boot method: a stage-1 chain loader built without UFS (the pack refuses if UFS comes back) that hands over to the device's own chainload/ directory. images refuses without that directory, and push and flash refuse qcom-abl before touching the phone, so nothing in the tree writes this phone yet; the guarded installer follows in a later pull request. The storage guard allows only boot_b and userdata. The Pixel images build byte for byte the same (tests/images-layout). tools/phone-smoke now counts warnings in the 7.x kernels' format, which changes the WARN count on every phone's report (it was always 0 before). The CI Tests failure on this head is the owl-idle timing flake fixed by derekross#207 (the run tested against a base from before it).
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
The matrix re-read against what merged and ran on hardware since 2026-11-02: - Pixel 7: Bluetooth and the torch move to testing (kernel derekross#196, derekross#197, derekross#426); fingerprint moves to WIP (kernel derekross#207; the package side, derekross#458, is in review); AVB footers and reboot=warm noted. - Pixel 8a: a new row, from first light and UFS behind the guard (kernel derekross#192, derekross#206; derekross#414). - Pixel 6 Pro: GPU scaling and cooling (kernel derekross#189) and UFS suspend (kernel derekross#188) merged. - Pixel 9a: GPU levels merged through kernel derekross#96; GNSS's moving-car session (derekross#114) and the link driver (kernel derekross#185). - Pixel 7a: Bluetooth's device tree merged (kernel derekross#98). The Pixel 8 Pro's row is left to derekross#472. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the check that has been failing the Tests job on pull requests that don't touch the home plugin (#206, #202, #166, #99 all failed it tonight). It isn't machine load, and it isn't the code under test: it's the check itself.
Phone.tickDelay(now, hidden)returnsperiod - now % period + 5, the time to the next boundary. With the home screen paused the period ishiddenTickMs(10000), so the next tick can legitimately be anywhere from 5 ms to 10005 ms away, and it is less thantickMs + 5(1005) whenever the clock sits in the last second of a period. That is 10 percent of the wall clock, which matches how this shows up: a run every so often, with no pattern and no relation to the change under test.The CI failure proves the mechanism rather than my guessing at it: the message printed 554 ms, which through
tickDelay()is a clock 9451 ms into its 10000 ms period, inside that last second.So the check now steps over the boundary before pausing, and only then asserts that the tick slows. The assertion itself is unchanged, as is everything it is testing; what goes away is one second in every ten where the assertion was false by design. Locally the suite passes, 30 runs of the original never happened to land in the window, which is why reading
tickDelay()was worth more than sampling.