Repository navigation
Conversation
…wer key does After the power key put the palmtop to sleep, a tap woke it and the panel showed the lock screen, but Hyprland still reported DPMS off and the panel's backlight device stayed powered down, so the panel driver refused the fingerprint circle (EPERM) until a power-key press ran the proper wake. omamobile-sleepd lit the lock screen only for a KEY_POWER wake; it now does the same for a wake from the touchscreen's interrupt (found as the parent device of the input device with INPUT_PROP_DIRECT), through omamobile-keys wake: the lock's wake, Hyprland's DPMS enable and the backlight. A test covers the touch wake and an unknown interrupt.
|
Thanks, nicely found, and the name match through Two things. First, main's shell is already at 0.2.44 (#184), so this needs the next free version; I'll set it at merge. Second, our published touch driver doesn't arm its interrupt for wake, so I'd like to see the touch interrupt really is the wake reason: once the 9a is off its drain test, could you tap-wake it and paste sleepd's |
# Conflicts: # packages/omamobile-shell/version
…d H5's wording The clock pad entry says what tegu-nfc-clkpad is and that it writes PMU 0x3e84 once through the kernel's SMC-backed regmap, never /dev/mem, with the boot unit's order and hang marker. The fingerprint-circle paragraph names the tap wake and points at omamobile-shell derekross#183. The USB-HOST-PLAN link has its target, and H5 reads Expect not met, within the stop window.
… with a parent A direct-touch input device without a device link (uinput, a test tool) listed before the real touchscreen would have given an empty name and masked it; such devices are skipped now, with a test for the case.
|
Rebased onto today's main (merge commit 24bc277, the version conflict resolved to 0.2.45) and the robustness idea is in at 77fd96d: touch_irq_name skips a direct-touch input device that has no device link, so a virtual device (uinput, a test tool) listed before the real touchscreen can't mask it, with a test for that case in test/sleepd.sh; the package's 237 checks and tools/pr-check pass. The tap-wake proof you asked for comes as soon as the owner can tap the palmtop, which is on its drain test right now: this change is already installed there as 0.2.41 with the sleep daemon restarted, so the "resumed, woken by IRQ …" line, Hyprland's DPMS state and the circle will come from that build, and if the wake IRQ turns out not to be the touchscreen's, the match gets changed. |
|
The proof run, with the fixed sleepd on the palmtop (hand-copied from this branch; the package build had installed a stale script): a forced So on this kernel a tap can't wake s2idle at all: the touchscreen's interrupt (IRQ 58, |
|
Two lock-side observations from this afternoon on the palmtop, for whoever picks the shell up next (not changes to this PR):
|
…is lit Restores this pull request's change: the merge at b3ceaf1 resolved to main's tree and dropped it. 0.2.46 and 0.2.47 are held by derekross#183 and derekross#197. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the proof run; it settled it. On today's kernels a tap can't wake s2idle on either phone, and the morning's state came from a screen-on without a suspend. I'd rather hold this until a touch driver arms its interrupt for wake. When that comes we'll also need to decide whether a touch should light the screen at all (stock doesn't, apart from AOD gestures), and it'll take the next free version then. The stale-DPMS-without-suspend case you found is worth its own issue. |
|
Closing for now. It was held until a touch driver can wake the phone, it conflicts with the shell since, and #420 now covers double-tap wake. If that path doesn't work out, this can be reopened and rebased. Thank you for it. |
Symptom, on the palmtop this morning: the power key turns the screen off and the phone sleeps a few seconds later; a tap wakes it and the lock screen shows, but
hyprctl monitors -jstill saysdpmsStatus: falseand the panel's backlight device readsbl_power4, so the panel driver refuseslocal_hbm_modewith EPERM and the fingerprint circle never appears on that lock screen. A power-key press in that state runs omamobile-keys' wake and everything is right at once (DPMS true, bl_power 0, circle, unlock).Cause: omamobile-sleepd lights the lock screen through
omamobile-keys wakeonly after a KEY_POWER wake. A touch wake got nothing: Hyprland never saw a wake action, so its DPMS state and the backlight power stayed as the sleep left them while the panel showed the lock.Change: sleepd treats a wake from the touchscreen's interrupt like the power key's. The interrupt is matched by name: the touch driver requests it under its device's name (the SPI device,
spi3.0on the 9a), found as the parent of the input device that has INPUT_PROP_DIRECT, so nothing is device-specific. An unknown interrupt is still a dark resume. Tests cover both.Test on a phone: power key off, wait for the sleep, tap to wake;
hyprctl monitors -jshows dpmsStatus true andbl_powerreads 0, and with the fingerprint stack up the circle appears on the lock screen without a power-key press.Not run on the palmtop yet (it is in a drain test with the cable out); the package tests pass and tools/pr-check is clean.