Skip to content

omamobile-fingerprint 0.1.12: allow LHBM on the Pixel 9a's panel too - #155

Merged
derekross merged 3 commits into
derekross:mainfrom
W4HO-ham:fingerprint-tegu-lhbm
Oct 30, 2026
Merged

derekross merged 3 commits into
derekross:mainfrom
W4HO-ham:fingerprint-tegu-lhbm

Conversation

@W4HO-ham

Copy link
Copy Markdown
Contributor

The follow-up you suggested on linux-omarchy-mobile#126: the 9a's panel driver (panel_google_tg4c) refuses the fingerprint circle unless allow_lhbm is set, the same pattern as cheetah's s6e3hc4, and until now the palmtop set it from a hand-written /etc/modprobe.d file. The package's omamobile-fingerprint-lhbm.conf now carries both panels' lines, so a fresh 9a install gets the circle without a hand step. On the 7 Pro nothing changes: the extra line names a module it doesn't load.

The kernel side is off by default until #126 merges, so this is safe to merge before it; the line simply has no effect until the driver is there.

Tests: packages/omamobile-fingerprint/test/all and tools/pr-check pass. On the palmtop the hand-written file is what sets it today; I'll install 0.1.12 and drop that file once it's on main.

The 9a's panel driver (panel_google_tg4c, linux-omarchy-mobile#126) refuses the fingerprint circle unless allow_lhbm is set, as cheetah's does, and until now the palmtop set it from a hand-written file in /etc/modprobe.d. The package's modprobe file now carries both panels' lines, so a fresh install gets the circle without a hand step.
@derekross

Copy link
Copy Markdown
Owner

Thank you, @W4HO-ham. This is the follow-up I had in mind, and it's nice and small.

I checked it on my side:

  • Nothing changes on my 7 Pro. Its panel_samsung_s6e3hc4 line is unchanged, and the new line only applies when panel_google_tg4c loads, which the 7 Pro never does.
  • The bridge doesn't need a rebuild. This PR doesn't touch fingerprint/. I also rebuilt the bridge from main and it matches my current prebuilt byte for byte. The package test passes on this branch with it.
  • 0.1.12 is free (main has 0.1.11), and the title works as the squash subject.

One small correction to the description, for the record. Without derekross/linux-omarchy-mobile#126 the line isn't quite silent. A panel_google_tg4c without the parameter still loads normally, but the kernel logs "unknown parameter 'allow_lhbm' ignored" once. That's harmless, but I'll merge this right after #126 so it never happens.

An optional suggestion: test/all doesn't look at the modprobe file at all. Two grep -c lines checking that both options lines are there would keep either phone's from being dropped by accident later. Not needed for this PR.

And as you said, please remove the hand-written file in /etc/modprobe.d on the palmtop once 0.1.12 is installed. If it has the same name as the package's file, it would hide the package's copy.

Thanks!

So that neither phone's line is dropped by accident later.
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Took the suggestion: test/all now checks that both options lines are in the staged modprobe file (702b6c2). Thanks for the note on the 'unknown parameter' line; merging after #126 is right. The hand-written file on the palmtop goes the moment 0.1.12 is installed (it has a different name, omamobile-tegu-fp-lhbm.conf, so it doesn't hide the package's; I'll remove it anyway).

@derekross

Copy link
Copy Markdown
Owner

Thanks for adding the test lines. Everything here is ready. I'm merging derekross/linux-omarchy-mobile#126 first, so the panel driver knows the parameter, and this one right after. One small thing: CI has no fingerprint prebuilts, so test/all exits at the "SKIP" line before it reaches the two new allow_lhbm checks. Moving them above the skip, so they read the modprobe file straight from vendor/, would make CI check them too; happy to take that as a follow-up.

…rebuilt skip

CI has no bionic prebuilts, so test/all stopped at its SKIP line before the two allow_lhbm checks. They now read the shipped vendor/modprobe.d file ahead of the skip, and the staged copy is only checked for existence.
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Done at 48f3333: the two allow_lhbm checks now run before the prebuilt SKIP, reading vendor/modprobe.d/omamobile-fingerprint-lhbm.conf as shipped, so CI covers them; the staged copy is checked for existence only. Verified on a checkout without prebuilts (passes, then skips the rest) and with the tg4c line removed (fails as it should). tools/pr-check passes.

@derekross
derekross merged commit 699da6a into derekross:main Oct 30, 2026
2 checks passed
@derekross

Copy link
Copy Markdown
Owner

Merged right after derekross/linux-omarchy-mobile#126, thank you, and thanks for moving the allow_lhbm checks above the skip so CI runs them.

derekross added a commit that referenced this pull request Oct 31, 2026
The Pixel 9a's SoC and board device tree, 120 Hz, the touchscreen and its
sleep fix, NFC's ST54L mode and poll stop, and the panel's local high
brightness mode are merged (kernel #80/#81, #88, #82, #131, #71, #126;
#155). The Pixel 8 Pro's buttons are in the published kernel (kernel
#148). The OnePlus 13's device package is merged (#111), mustang has stage
0 notes (#198), and kodiak joins the Pixel 11 row (#201).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…erekross#155)

The fingerprint package's modprobe file now sets allow_lhbm for the Pixel 9a's TG4C panel as well as the Pixel 7 Pro's, so the under-display sensor gets its local high brightness spot on the 9a (the driver side landed in linux-omarchy-mobile#126). The package test checks both panels' lines before the bionic-prebuilt skip, so CI runs them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
The Pixel 9a's SoC and board device tree, 120 Hz, the touchscreen and its
sleep fix, NFC's ST54L mode and poll stop, and the panel's local high
brightness mode are merged (kernel derekross#80/derekross#81, derekross#88, derekross#82, derekross#131, derekross#71, derekross#126;
derekross#155). The Pixel 8 Pro's buttons are in the published kernel (kernel
derekross#148). The OnePlus 13's device package is merged (derekross#111), mustang has stage
0 notes (derekross#198), and kodiak joins the Pixel 11 row (derekross#201).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants