Repository navigation
docs/review: lessons from review rounds 27 and 28 - #151
Merged
Merged
Conversation
Twenty-four lessons (L-294 to L-317) from the omamobile-reviewer runs of rounds 27 and 28, and one correction (C-19): round 27 asked for the USB-host module "on a branch or as a draft PR" without naming the repository, which put a kernel module and DT fragment in this one. Five candidates were dropped as already covered and three CI-runner candidates were merged into L-311. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 31, 2026
…ss#150 alone fixes GNSS The maintainer asked whether the CRC improvement holds with the SPI flush fix alone at the bootloader's drive 0. It does: 50 of 53 GGA fixed, every received frame at bit offset 0 with a valid CRC32, the same as at drive 3. Kernel derekross#151 is closed; the plan's cause 2, the notes and the AGENTS gotcha now say so, and the gotcha keeps the lesson: one change per boot, and check whose pins they are first.
W4HO-ham
added a commit
to W4HO-ham/omarchy-mobile
that referenced
this pull request
Oct 31, 2026
…of 10-31 Both NOTES entries kept, and the 10-29 bullet no longer credits drive 3. The status line and the script headers drop "resolved", linux-omarchy-mobile#150 is merged, derekross#150 and derekross#151 are written in full, HOLD=1 is the attended default, and the link section has today's substate result.
derekross
added a commit
that referenced
this pull request
Oct 31, 2026
… rounds L-348 to L-361: shared drivers judged against every int-line user (#150), board pins against every stock user (#151), ownership flags under the consumer's lock (#152), /chosen children and Google's panel constants (#154), same-day notes PRs on one device (#208/#209), merge simulations for DEVICES rows, ours included (#165), stacked PRs that merged main (#115/#117), titles behind renumbered versions, a contributor merge that dropped the PR (#99), smoke package lists as provenance and "owner-authorized" writes (#200), promised fixes and named tags checked on the remote (#153/#157/#158), and file swaps into old packages (#193). C-23 (usbc-deadman's device scope, kernel #107) and C-24 (BNEP in a lynx-only fragment, #98). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross
pushed a commit
that referenced
this pull request
Nov 1, 2026
The 9a's GNSS gets a position fix: up to 13 satellites used, HDOP 0.8-1.2, GPS, Galileo, BeiDou and GLONASS tracked, CHPP clean. Two kernel fixes did it: spi-s3c64xx's FIFO flush order (kernel #150) and SPI21's pinctrl (kernel #151). With them stock's SPI configuration works and the byte swap is done in gnss_spi. MODEM-PLAN gains a "G3, resolved" section (causes, configuration, the link-hold answer, what's left); tegu-gnss-start now defaults to HOLD=0, with HOLD=1/2 kept as diagnostics, and three later sessions went through omamobile-gnss 0.2.5's start with the modem link left to cycle. AGENTS gains the flush-order and missing-pinctrl gotchas and the keep_link_up rule. NOTES gets a dated entry, and the run kit's bring-up overlays and session script are recorded, each marked bring-up only. Nothing locating the owner is recorded. Maintainer edit at merge: the Location paragraph no longer counts omamobile-gnss 0.2.5's hang marker as a safety net for the hand drop-ins, which replace the package's start and write no marker. Closes #202 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
Twenty-four lessons (L-294 to L-317) from the omamobile-reviewer runs of rounds 27 and 28, and one correction (C-19): round 27 asked for the USB-host module "on a branch or as a draft PR" without naming the repository, which put a kernel module and DT fragment in this one. Five candidates were dropped as already covered and three CI-runner candidates were merged into L-311. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
… rounds L-348 to L-361: shared drivers judged against every int-line user (derekross#150), board pins against every stock user (derekross#151), ownership flags under the consumer's lock (derekross#152), /chosen children and Google's panel constants (derekross#154), same-day notes PRs on one device (derekross#208/derekross#209), merge simulations for DEVICES rows, ours included (derekross#165), stacked PRs that merged main (derekross#115/derekross#117), titles behind renumbered versions, a contributor merge that dropped the PR (derekross#99), smoke package lists as provenance and "owner-authorized" writes (derekross#200), promised fixes and named tags checked on the remote (derekross#153/derekross#157/derekross#158), and file swaps into old packages (derekross#193). C-23 (usbc-deadman's device scope, kernel derekross#107) and C-24 (BNEP in a lynx-only fragment, derekross#98). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
) The 9a's GNSS gets a position fix: up to 13 satellites used, HDOP 0.8-1.2, GPS, Galileo, BeiDou and GLONASS tracked, CHPP clean. Two kernel fixes did it: spi-s3c64xx's FIFO flush order (kernel derekross#150) and SPI21's pinctrl (kernel derekross#151). With them stock's SPI configuration works and the byte swap is done in gnss_spi. MODEM-PLAN gains a "G3, resolved" section (causes, configuration, the link-hold answer, what's left); tegu-gnss-start now defaults to HOLD=0, with HOLD=1/2 kept as diagnostics, and three later sessions went through omamobile-gnss 0.2.5's start with the modem link left to cycle. AGENTS gains the flush-order and missing-pinctrl gotchas and the keep_link_up rule. NOTES gets a dated entry, and the run kit's bring-up overlays and session script are recorded, each marked bring-up only. Nothing locating the owner is recorded. Maintainer edit at merge: the Location paragraph no longer counts omamobile-gnss 0.2.5's hang marker as a safety net for the hand drop-ins, which replace the package's start and write no marker. Closes derekross#202 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twenty-four lessons (L-294 to L-317) and one correction (C-19) from review rounds 27 and 28.
device/<codename>/kernel.config, not the shared fragment.Docs only; no numbering duplicates (317 entries).
🤖 Generated with Claude Code