Repository navigation
omamobile-fingerprint 0.1.11: touches in panel pixels, the circle lit before the capture, the refresh rate the HAL parses - #135
Conversation
… before the capture, and the refresh rate the HAL parses On the Pixel 9a every authenticate touch came back ACQUIRED_PARTIAL. Three things were wrong, all found from the HAL's own log. The bridge scaled touches to panel pixels for its own hit test but handed the HAL the raw touchscreen values, ten times too large (5432,17847 for a finger on the 540,1756 circle), so the HAL saw every finger off the sensor. It now sends the scaled position. The HAL captures at onPointerDownWithContext, not at onUiReady, so the circle was still dark for the first frame. The bridge now lights the circle and waits the settle time before it reports the finger. The HAL reads the refresh rate from panel0-backlight/state after its "@" (gs-panel's "on: WxH@Hz") and logged "Failed to parse refresh rate" on our bare "on". The runner now writes the panel's size and rate, per device (cheetah 60 Hz, tegu 120 Hz, the rate the 9a's local HBM needs). With these, captures are GOOD and reach the matcher (NOMATCH rather than PARTIAL); image quality is still low (15-26) and matching is the next step.
|
Update from the palmtop (2026-10-29): with these three fixes plus tg4c's LHBM on the panel's normal bands, matching works. The enrolled finger gave MATCH on the first touch twice, and a different finger gave NOMATCH. Through fprintd, enrollment and verify work, and the lock screen unlocks with the enrolled finger and refuses a different one. The panel side is coming as a kernel PR on top of linux-omarchy-mobile#125 (DCS reads). The results are in #138's FINGERPRINT-PLAN. |
|
Thank you for this. Tracking all three causes down from the HAL's own log is careful work, and the update that the palmtop now matches and unlocks is great to read. The tegu side looks right to me. Before I merge, there's one thing to sort out for the Pixel 7 Pro, and one thing I have to do on my side. The 7 Pro changes more than the description says. Fingerprint unlock works on my 7 Pro every day, and this package and the bridge are shared. Here's what I found for cheetah:
The project's rule for shared code is that the 7 Pro stays as it is unless there's a reason that holds there too and a run on my phone before the merge. The simplest way through:
Two small things while you're in there (not blocking):
Evidence for the PR (CONTRIBUTING §6.5): please add On my side: the package installs a bridge that I build by hand, and this PR changes only the bridge's code, not its options. So the check from #129 passes even with today's bridge. I confirmed that: the test passes with main's prebuilt, which I rebuilt byte for byte from main's source. Before the next publish after this merges, I'll rebuild the bridge on my laptop and on the build machine, and I'll run the 7 Pro check. Squash title and version (0.1.11, free on main) look right. CI is green. |
… line Review: the reorder and the rate in the backlight state are the 9a's needs, so both are per device now. The 9a passes --lhbm-first 1 and writes gs_panel's "On: 1080x2424@120"; the 7 Pro keeps pointer down before the circle and its bare "on". The PointerContext time is taken after the settle, and the package test checks each phone's values under set -u.
|
Thanks, all done in ba4d1f2. Both behaviours are now per device, so the 7 Pro stays as it was:
Evidence from the palmtop, with the bridge and runner built from this head and installed by hand over package 0.1.8 (the bridge with NDK r30 against the image's The failed phone-smoke: teguKernel
Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.22, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-audio 0.4.1-1, omamobile-device-tegu 0.1.0-1, omamobile-fingerprint 0.1.8-1, omamobile-firstboot 0.1.0-1, omamobile-gnss 0.2.1-1, omamobile-keyring 20261013-1, omamobile-mirror 0.1.1-1, omamobile-modem 0.1.4-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-sensors 0.2.1-1, omamobile-shell 0.2.36-1, omarchy 4.0.6-1 |
|
Morning check on this exact build (the 0.1.11 bridge and runner, |
|
Thank you, both for the rework and for the morning re-run on the exact build. Keeping the 7 Pro's behaviour behind I went through each point from my last comment against ba4d1f2:
I also built the bridge from this head with the project's Makefile ( So this is ready from my side. What happens next is on me:
One note for later, nothing to do here: matching on the 9a also depends on the panel change you mentioned (LHBM on tg4c's normal bands), which isn't in a kernel PR yet. Until it is, the 9a's fingerprint status should say it needs that change. Thanks again. Finding all three causes in the HAL's log and then splitting them cleanly per phone made this easy to review. |
…ile#138 now Kernel derekross#135 went up without a sign-off and is replaced by derekross#138 with the same two commits; the parked paragraph links the live one.
… before the capture, the refresh rate the HAL parses (derekross#135) On the Pixel 9a every authenticate touch came back ACQUIRED_PARTIAL. The bridge now hands the HAL touch positions in panel pixels (it scaled them only for its own hit test; no change on the 7 Pro, whose touch range equals the panel). Two 9a-only settings: --lhbm-first 1 lights the circle and waits the settle time before onPointerDown, since the 9a's HAL captures there, and the runner writes gs_panel's "On: 1080x2424@120" to the backlight state, where the HAL parses the rate. The 7 Pro keeps pointer down before the circle and its bare "on". Captures on the 9a are GOOD and match the enrolled finger. The bridge gains an option, so the prebuilt must be rebuilt. Co-authored-by: W4HO-ham <87742609+W4HO-ham@users.noreply.github.com>
On the palmtop (Pixel 9a) every authenticate touch came back ACQUIRED_PARTIAL. The HAL's log showed three causes:
onPointerDownWithContext, not atonUiReady, so the circle was still dark when it took the picture. The bridge now lights the circle and waits the settle time before it reports the finger.panel0-backlight/stateafter the "@" (gs-panel'son: WxH@Hz), and it logged "Failed to parse refresh rate" on our bareon. The runner now writes the panel size and rate per device: cheetah 60, tegu 120, which is the rate the 9a's local HBM needs.Tested on the palmtop: enrollment completes, and authenticate captures come back GOOD and reach the matcher (NOMATCH instead of PARTIAL). Matching itself still fails, with image quality 15-26, so that's next. The 7 Pro only gets the per-device rate (60, as before) plus the touch fix; I haven't rerun it there.